Re: [FFmpeg-devel] [PATCH]lavf/gsmdec: Add a probe function

2016-04-10 Thread Carl Eugen Hoyos
Carl Eugen Hoyos ag.or.at> writes: > Attached is a probe function for gsm and a patch for a gsm > muxer to allow testing. The file format is for example > supported by sox. Patches applied. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmp

Re: [FFmpeg-devel] [PATCH]lavf/gsmdec: Add a probe function

2016-04-06 Thread Paul B Mahol
On 4/5/16, Carl Eugen Hoyos wrote: > Paul B Mahol gmail.com> writes: > >> > Attached is a probe function for gsm > >> What heuristic you used to write this code? > > The decoder rejects frames that do not start with 0xdx. > > Are you unhappy with the probe function? It should be fine if it passe

Re: [FFmpeg-devel] [PATCH]lavf/gsmdec: Add a probe function

2016-04-05 Thread Carl Eugen Hoyos
Paul B Mahol gmail.com> writes: > > Are you unhappy with the probe function? > > Is it too hard or too soft? > > It seems it breaks fate. The gsm muxer (not the probe function) broke fate because I badly edited allformats.c and "removed" the gif demuxer: As said, I consider this an interesti

Re: [FFmpeg-devel] [PATCH]lavf/gsmdec: Add a probe function

2016-04-05 Thread Paul B Mahol
On 4/5/16, Carl Eugen Hoyos wrote: > Paul B Mahol gmail.com> writes: > >> > Attached is a probe function for gsm > >> What heuristic you used to write this code? > > The decoder rejects frames that do not start with 0xdx. > > Are you unhappy with the probe function? > Is it too hard or too soft?

Re: [FFmpeg-devel] [PATCH]lavf/gsmdec: Add a probe function

2016-04-05 Thread Carl Eugen Hoyos
Paul B Mahol gmail.com> writes: > > Attached is a probe function for gsm > What heuristic you used to write this code? The decoder rejects frames that do not start with 0xdx. Are you unhappy with the probe function? Is it too hard or too soft? Carl Eugen _

Re: [FFmpeg-devel] [PATCH]lavf/gsmdec: Add a probe function

2016-04-02 Thread Paul B Mahol
On 4/2/16, Carl Eugen Hoyos wrote: > Hi! > > Attached is a probe function for gsm and a patch for a gsm muxer to allow > testing. The file format is for example supported by sox. > > Please comment, Carl Eugen > What heuristic you used to write this code? _

Re: [FFmpeg-devel] [PATCH]lavf/gsmdec: Add a probe function

2016-04-02 Thread Michael Niedermayer
On Sat, Apr 02, 2016 at 10:29:20AM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached is a probe function for gsm and a patch for a gsm muxer to allow > testing. The file format is for example supported by sox. > > Please comment, Carl Eugen breaks fate-gif-deal somehow Consider increasing the

[FFmpeg-devel] [PATCH]lavf/gsmdec: Add a probe function

2016-04-02 Thread Carl Eugen Hoyos
Hi! Attached is a probe function for gsm and a patch for a gsm muxer to allow testing. The file format is for example supported by sox. Please comment, Carl Eugen diff --git a/libavformat/gsmdec.c b/libavformat/gsmdec.c index 97dd8c5..f6fb08e 100644 --- a/libavformat/gsmdec.c +++ b/libavformat/g