Re: [FFmpeg-devel] [PATCH]lavf/concatdec: Allocate the filenames on the heap

2017-10-24 Thread Nicolas George
> 2017-10-21 18:29 GMT+02:00 Nicolas George : > > Yes, exactly. This limitation was the reason I did not bother handling > > longer lines. I would like to understand how it makes a difference. The answer is: the filename field in AVFormatContext is not used to open the file, only the argument to a

Re: [FFmpeg-devel] [PATCH]lavf/concatdec: Allocate the filenames on the heap

2017-10-21 Thread Marton Balint
On Sat, 21 Oct 2017, Carl Eugen Hoyos wrote: 2017-10-21 18:29 GMT+02:00 Nicolas George : Le decadi 30 vendémiaire, an CCXXVI, Marton Balint a écrit : I thought filenames in libavformat are limited to 1K anyway because of the AVFormatContext->filename field. How can I reproduce this? I test

Re: [FFmpeg-devel] [PATCH]lavf/concatdec: Allocate the filenames on the heap

2017-10-21 Thread Carl Eugen Hoyos
2017-10-21 18:29 GMT+02:00 Nicolas George : > Le decadi 30 vendémiaire, an CCXXVI, Marton Balint a écrit : >> I thought filenames in libavformat are limited to 1K anyway >> because of the AVFormatContext->filename field. How can I reproduce this? I tested the data from the ticket from the command

Re: [FFmpeg-devel] [PATCH]lavf/concatdec: Allocate the filenames on the heap

2017-10-21 Thread Nicolas George
Le decadi 30 vendémiaire, an CCXXVI, Marton Balint a écrit : > I thought filenames in libavformat are limited to 1K anyway because of the > AVFormatContext->filename field. So if your patch really fixes the ticket, > then how? :) Yes, exactly. This limitation was the reason I did not bother handli

Re: [FFmpeg-devel] [PATCH]lavf/concatdec: Allocate the filenames on the heap

2017-10-21 Thread Marton Balint
On Fri, 20 Oct 2017, Carl Eugen Hoyos wrote: Hi! I believe that the use-case is valid and there is definitely a bug because no error is shown for too long filenames. In addition, allocating 50k on the heap seems nicer than 4k on the stack. 50k is not much better than 4k. You should add an f

[FFmpeg-devel] [PATCH]lavf/concatdec: Allocate the filenames on the heap

2017-10-20 Thread Carl Eugen Hoyos
Hi! I believe that the use-case is valid and there is definitely a bug because no error is shown for too long filenames. In addition, allocating 50k on the heap seems nicer than 4k on the stack. Please comment, Carl Eugen From e25b8e6b77e3b9b661f1ce00beeef7e057929ba3 Mon Sep 17 00:00:00 2001 From