Re: [FFmpeg-devel] [PATCH]lavd/decklink_dec: Make bitrate calculation 64bit

2016-05-03 Thread Carl Eugen Hoyos
Matthias Hunstock fem.tu-ilmenau.de> writes: > Am 28.04.2016 um 17:27 schrieb Carl Eugen Hoyos: > > > I hope attached patch fixes an issue seen in a decklink user > > report where the bit_rate was negative. > I'd really like to reproduce and have a further look. This is all information I have

Re: [FFmpeg-devel] [PATCH]lavd/decklink_dec: Make bitrate calculation 64bit

2016-05-03 Thread Matthias Hunstock
Am 28.04.2016 um 17:27 schrieb Carl Eugen Hoyos: > I hope attached patch fixes an issue seen in a decklink user report where > the bit_rate was negative. Or should the division be changed to 1ULL/...? > Completely untested. > > Please review, Carl Eugen It seems that av_image_get_buffer_size

Re: [FFmpeg-devel] [PATCH]lavd/decklink_dec: Make bitrate calculation 64bit

2016-04-29 Thread Matthias Hunstock
Am 28.04.2016 um 17:27 schrieb Carl Eugen Hoyos: > Please review, Carl Eugen Is there a ticket number? Matthias ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavd/decklink_dec: Make bitrate calculation 64bit

2016-04-28 Thread Michael Niedermayer
On Thu, Apr 28, 2016 at 05:30:36PM +0200, Nicolas George wrote: > Le decadi 10 floréal, an CCXXIV, Carl Eugen Hoyos a écrit : > > I hope attached patch fixes an issue seen in a decklink user report where > > the bit_rate was negative. Or should the division be changed to 1ULL/...? > > This does n

Re: [FFmpeg-devel] [PATCH]lavd/decklink_dec: Make bitrate calculation 64bit

2016-04-28 Thread Nicolas George
Le decadi 10 floréal, an CCXXIV, Carl Eugen Hoyos a écrit : > I hope attached patch fixes an issue seen in a decklink user report where > the bit_rate was negative. Or should the division be changed to 1ULL/...? This does not make the computation 64 bits, it makes them whatever the size happens t

[FFmpeg-devel] [PATCH]lavd/decklink_dec: Make bitrate calculation 64bit

2016-04-28 Thread Carl Eugen Hoyos
Hi! I hope attached patch fixes an issue seen in a decklink user report where the bit_rate was negative. Or should the division be changed to 1ULL/...? Completely untested. Please review, Carl Eugen diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 9d7dc97..89c1a8b 1