Re: [FFmpeg-devel] [PATCH]lavc/psd: Support CMYK images

2019-01-12 Thread Carl Eugen Hoyos
2019-01-11 7:17 GMT+01:00, Peter Ross : > On Fri, Jan 11, 2019 at 03:23:49AM +0100, Carl Eugen Hoyos wrote: >> 2019-01-11 2:55 GMT+01:00, Carl Eugen Hoyos : >> > Hi! >> > >> > Attached patch fixes ticket #6797, please comment. >> >> New patch with 16bit support attached. >> >> Please comment, Carl

Re: [FFmpeg-devel] [PATCH]lavc/psd: Support CMYK images

2019-01-11 Thread Derek Buitenhuis
On 11/01/2019 14:20, Carl Eugen Hoyos wrote: > Yes, but they can have different representations in FFmpeg. I suppose the "correct" fix is to put it in swscale, but noone is going to want to do that. > Is this patch ok? No strong opinion. I doubt anyone will want to patch swscale, so I suppose it

Re: [FFmpeg-devel] [PATCH]lavc/psd: Support CMYK images

2019-01-11 Thread Carl Eugen Hoyos
2019-01-11 14:05 GMT+01:00, Derek Buitenhuis : > On 11/01/2019 06:17, Peter Ross wrote: >> the same algorithm exists in libavcodec/mjpegdec.c, with alpha channel >> support. >> i guess it is trivial enough to be duplicated here. > > Is it worth deduplicating? Plenty of image formats have CMYK. Yes

Re: [FFmpeg-devel] [PATCH]lavc/psd: Support CMYK images

2019-01-11 Thread Derek Buitenhuis
On 11/01/2019 06:17, Peter Ross wrote: > the same algorithm exists in libavcodec/mjpegdec.c, with alpha channel > support. > i guess it is trivial enough to be duplicated here. Is it worth deduplicating? Plenty of image formats have CMYK. - Derek ___ f

Re: [FFmpeg-devel] [PATCH]lavc/psd: Support CMYK images

2019-01-10 Thread Peter Ross
On Fri, Jan 11, 2019 at 03:23:49AM +0100, Carl Eugen Hoyos wrote: > 2019-01-11 2:55 GMT+01:00, Carl Eugen Hoyos : > > Hi! > > > > Attached patch fixes ticket #6797, please comment. > > New patch with 16bit support attached. > > Please comment, Carl Eugen > From 5f879539ee7fecd57bd3de9f7c6363d9b7

Re: [FFmpeg-devel] [PATCH]lavc/psd: Support CMYK images

2019-01-10 Thread Carl Eugen Hoyos
2019-01-11 2:55 GMT+01:00, Carl Eugen Hoyos : > Hi! > > Attached patch fixes ticket #6797, please comment. New patch with 16bit support attached. Please comment, Carl Eugen From 5f879539ee7fecd57bd3de9f7c6363d9b7779b5b Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 11 Jan 2019 03:20:

[FFmpeg-devel] [PATCH]lavc/psd: Support CMYK images

2019-01-10 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #6797, please comment. Carl Eugen From f0d1c43a791f44eee5ae3174baf367a73e59283e Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 11 Jan 2019 02:53:06 +0100 Subject: [PATCH] lavc/psd: Support CMYK images. Fixes ticket #6797. --- libavcodec/psd.c | 43