Re: [FFmpeg-devel] [PATCH]lavc/psd: Interpret duotone as grayscale

2017-01-10 Thread Martin Vignali
> > Feel free to look at my 32bit patch attached to ticket #6045, perhaps > you know how to fix it. > > I think 32bit in psd are for float data, maybe something like the float to 16i used inside exr. Doesn't tested, and i will not have time to take a better look soon. Martin _

Re: [FFmpeg-devel] [PATCH]lavc/psd: Interpret duotone as grayscale

2017-01-10 Thread Carl Eugen Hoyos
2017-01-10 23:57 GMT+01:00 Martin Vignali : > I don't have a strong opinion about duo tone (i never use it) > >> Seems not the best way to manage this kind of file >> >> Not sure if I understand: >> What is the alternative? Do you know how to interpret >> the duotone specification? >> > > I think i

Re: [FFmpeg-devel] [PATCH]lavc/psd: Interpret duotone as grayscale

2017-01-10 Thread Martin Vignali
I don't have a strong opinion about duo tone (i never use it) > Seems not the best way to manage this kind of file > > Not sure if I understand: > What is the alternative? Do you know how to interpret > the duotone specification? > I think it's better to have the real color :-) But i don't know h

Re: [FFmpeg-devel] [PATCH]lavc/psd: Interpret duotone as grayscale

2017-01-10 Thread Carl Eugen Hoyos
2017-01-10 23:23 GMT+01:00 Martin Vignali : >> > Seems strange, that duotone is interpreted like grayscale >> >> It's what gimp, ImageMagick and FreeImage do and what Adobe recommends. > > Seems to be also the case of Apple Preview. > > Seems not the best way to manage this kind of file Not sure i

Re: [FFmpeg-devel] [PATCH]lavc/psd: Interpret duotone as grayscale

2017-01-10 Thread Martin Vignali
> > Seems strange, that duotone is interpreted like grayscale > > It's what gimp, ImageMagick and FreeImage do and what Adobe recommends. > > > Seems to be also the case of Apple Preview. Seems not the best way to manage this kind of file Doesn't know the general rules of this project, about that

Re: [FFmpeg-devel] [PATCH]lavc/psd: Interpret duotone as grayscale

2017-01-10 Thread Carl Eugen Hoyos
2017-01-10 18:42 GMT+01:00 Martin Vignali : > Seems strange, that duotone is interpreted like grayscale It's what gimp, ImageMagick and FreeImage do and what Adobe recommends. Did you see the BITMAP patch? Carl Eugen ___ ffmpeg-devel mailing list ffmp

Re: [FFmpeg-devel] [PATCH]lavc/psd: Interpret duotone as grayscale

2017-01-10 Thread Martin Vignali
Hello, Seems strange, that duotone is interpreted like grayscale (i doesn't test yet your patch) You can find a sample here (and an rgb png of the result in photoshop), for a duotone file with color https://we.tl/mbvMt5bytk I think, duotone, need to be interpreted using information in Image Ress

[FFmpeg-devel] [PATCH]lavc/psd: Interpret duotone as grayscale

2017-01-10 Thread Carl Eugen Hoyos
Hi! Attached patch does what other applications do with duotone and fixes the provided sample. Please comment, Carl Eugen From 32f777d3a63007a91ab3c08990bface1bbf79be9 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Tue, 10 Jan 2017 17:49:31 +0100 Subject: [PATCH] lavc/psd: Interpret DUOT