Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-21 Thread Carl Eugen Hoyos
2018-12-17 2:47 GMT+01:00, Carl Eugen Hoyos : > The Opus struct RawBitsContext is used in both the decoder and the encoder. > The fact that *position is const avoids warnings in the decoder where > it points into the bitstream. The encoder writes into the same > pointer, attached cast silences the

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-19 Thread Carl Eugen Hoyos
2018-12-17 2:47 GMT+01:00, Carl Eugen Hoyos : > The Opus struct RawBitsContext is used in both the decoder and the encoder. > The fact that *position is const avoids warnings in the decoder where > it points into the bitstream. The encoder writes into the same > pointer, attached cast silences the

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-19 Thread Nicolas George
Paul B Mahol (2018-12-17): > Yes, it is poc - patch of crap. Please refrain from using that language. -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/lis

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 22:37 GMT+01:00, Paul B Mahol : > On 12/17/18, Carl Eugen Hoyos wrote: >> 2018-12-17 22:29 GMT+01:00, Paul B Mahol : >>> On 12/17/18, Carl Eugen Hoyos wrote: 2018-12-17 22:26 GMT+01:00, Paul B Mahol : > On 12/17/18, Carl Eugen Hoyos wrote: >> 2018-12-17 2:47 GMT+01:00, Ca

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Paul B Mahol
On 12/17/18, Carl Eugen Hoyos wrote: > 2018-12-17 22:29 GMT+01:00, Paul B Mahol : >> On 12/17/18, Carl Eugen Hoyos wrote: >>> 2018-12-17 22:26 GMT+01:00, Paul B Mahol : On 12/17/18, Carl Eugen Hoyos wrote: > 2018-12-17 2:47 GMT+01:00, Carl Eugen Hoyos : > >> The Opus struct RawB

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 22:29 GMT+01:00, Paul B Mahol : > On 12/17/18, Carl Eugen Hoyos wrote: >> 2018-12-17 22:26 GMT+01:00, Paul B Mahol : >>> On 12/17/18, Carl Eugen Hoyos wrote: 2018-12-17 2:47 GMT+01:00, Carl Eugen Hoyos : > The Opus struct RawBitsContext is used in both the decoder and the

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Paul B Mahol
On 12/17/18, Carl Eugen Hoyos wrote: > 2018-12-17 22:26 GMT+01:00, Paul B Mahol : >> On 12/17/18, Carl Eugen Hoyos wrote: >>> 2018-12-17 2:47 GMT+01:00, Carl Eugen Hoyos : >>> The Opus struct RawBitsContext is used in both the decoder and the encoder. The fact that *position is con

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 22:26 GMT+01:00, Paul B Mahol : > On 12/17/18, Carl Eugen Hoyos wrote: >> 2018-12-17 2:47 GMT+01:00, Carl Eugen Hoyos : >> >>> The Opus struct RawBitsContext is used in both the decoder and the >>> encoder. >>> The fact that *position is const avoids warnings in the decoder where >>> it

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Paul B Mahol
On 12/17/18, Carl Eugen Hoyos wrote: > 2018-12-17 2:47 GMT+01:00, Carl Eugen Hoyos : > >> The Opus struct RawBitsContext is used in both the decoder and the >> encoder. >> The fact that *position is const avoids warnings in the decoder where >> it points into the bitstream. The encoder writes into

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 2:47 GMT+01:00, Carl Eugen Hoyos : > The Opus struct RawBitsContext is used in both the decoder and the encoder. > The fact that *position is const avoids warnings in the decoder where > it points into the bitstream. The encoder writes into the same > pointer, attached cast silences the

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Paul B Mahol
On 12/17/18, Carl Eugen Hoyos wrote: > 2018-12-17 22:02 GMT+01:00, Paul B Mahol : >> On 12/17/18, Carl Eugen Hoyos wrote: >>> 2018-12-17 21:35 GMT+01:00, Rostislav Pehlivanov : On Mon, 17 Dec 2018 at 01:47, Carl Eugen Hoyos wrote: > Hi! > > The Opus struct RawBitsConte

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 22:02 GMT+01:00, Paul B Mahol : > On 12/17/18, Carl Eugen Hoyos wrote: >> 2018-12-17 21:35 GMT+01:00, Rostislav Pehlivanov : >>> On Mon, 17 Dec 2018 at 01:47, Carl Eugen Hoyos >>> wrote: >>> Hi! The Opus struct RawBitsContext is used in both the decoder and the enco

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Paul B Mahol
On 12/17/18, Carl Eugen Hoyos wrote: > 2018-12-17 21:35 GMT+01:00, Rostislav Pehlivanov : >> On Mon, 17 Dec 2018 at 01:47, Carl Eugen Hoyos wrote: >> >>> Hi! >>> >>> The Opus struct RawBitsContext is used in both the decoder and the >>> encoder. >>> The fact that *position is const avoids warning

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 21:53 GMT+01:00, Carl Eugen Hoyos : > 2018-12-17 21:35 GMT+01:00, Rostislav Pehlivanov : >> On Mon, 17 Dec 2018 at 01:47, Carl Eugen Hoyos >> wrote: >> >>> Hi! >>> >>> The Opus struct RawBitsContext is used in both the decoder and the >>> encoder. >>> The fact that *position is const av

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 21:35 GMT+01:00, Rostislav Pehlivanov : > On Mon, 17 Dec 2018 at 01:47, Carl Eugen Hoyos wrote: > >> Hi! >> >> The Opus struct RawBitsContext is used in both the decoder and the >> encoder. >> The fact that *position is const avoids warnings in the decoder where >> it points into the bi

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Rostislav Pehlivanov
On Mon, 17 Dec 2018 at 01:47, Carl Eugen Hoyos wrote: > Hi! > > The Opus struct RawBitsContext is used in both the decoder and the encoder. > The fact that *position is const avoids warnings in the decoder where > it points into the bitstream. The encoder writes into the same > pointer, attached

[FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-16 Thread Carl Eugen Hoyos
Hi! The Opus struct RawBitsContext is used in both the decoder and the encoder. The fact that *position is const avoids warnings in the decoder where it points into the bitstream. The encoder writes into the same pointer, attached cast silences the warning on targets where AV_WB32() does not inter