Re: [FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

2015-12-25 Thread Roger Pack
On 12/11/15, Lou Logan wrote: > On Wed, 9 Dec 2015 21:24:06 +0100, Hendrik Leppkes wrote: > >> libvo-aacenc doesn't see any development anymore. >> Its an encoder taken from the android sdk a long time ago, but AOSP >> replaced it with fdk-aac, so libvo-aacenc is EOL. >> >> And its quality is horr

Re: [FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

2015-12-11 Thread Lou Logan
On Wed, 9 Dec 2015 21:24:06 +0100, Hendrik Leppkes wrote: > libvo-aacenc doesn't see any development anymore. > Its an encoder taken from the android sdk a long time ago, but AOSP > replaced it with fdk-aac, so libvo-aacenc is EOL. > > And its quality is horrible. We should remove the wrapper. I

Re: [FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

2015-12-10 Thread Hendrik Leppkes
On Fri, Dec 11, 2015 at 12:07 AM, Carl Eugen Hoyos wrote: > On Wednesday 09 December 2015 09:24:06 pm Hendrik Leppkes wrote: >> On Wed, Dec 9, 2015 at 7:09 PM, James Almer wrote: >> > On 12/5/2015 9:31 PM, Carl Eugen Hoyos wrote: >> >> Hi! >> >> >> >> I prefer attached patch over removing the enc

Re: [FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

2015-12-10 Thread Carl Eugen Hoyos
On Wednesday 09 December 2015 09:24:06 pm Hendrik Leppkes wrote: > On Wed, Dec 9, 2015 at 7:09 PM, James Almer wrote: > > On 12/5/2015 9:31 PM, Carl Eugen Hoyos wrote: > >> Hi! > >> > >> I prefer attached patch over removing the encoder immediately. > And its quality is horrible. > > No idea why

Re: [FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

2015-12-09 Thread Hendrik Leppkes
On Wed, Dec 9, 2015 at 7:09 PM, James Almer wrote: > On 12/5/2015 9:31 PM, Carl Eugen Hoyos wrote: >> Hi! >> >> I prefer attached patch over removing the encoder immediately. >> >> Carl Eugen > > What is experimental? Our wrapper or the library? > If the latter then maybe it would be better to use

Re: [FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

2015-12-09 Thread James Almer
On 12/5/2015 9:31 PM, Carl Eugen Hoyos wrote: > Hi! > > I prefer attached patch over removing the encoder immediately. > > Carl Eugen What is experimental? Our wrapper or the library? If the latter then maybe it would be better to use a static init function to mark the encoder as experimental af

Re: [FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

2015-12-09 Thread Claudio Freire
On Wed, Dec 9, 2015 at 11:15 AM, Carl Eugen Hoyos wrote: > On Sunday 06 December 2015 01:31:17 am Carl Eugen Hoyos wrote: >> Hi! >> >> I prefer attached patch over removing the encoder immediately. > > No opinions? > > Carl Eugen LGTM, but I don't use the libvo-aac, so... :-p ___

Re: [FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

2015-12-09 Thread Carl Eugen Hoyos
On Sunday 06 December 2015 01:31:17 am Carl Eugen Hoyos wrote: > Hi! > > I prefer attached patch over removing the encoder immediately. No opinions? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmp

[FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

2015-12-05 Thread Carl Eugen Hoyos
Hi! I prefer attached patch over removing the encoder immediately. Carl Eugen diff --git a/Changelog b/Changelog index ad13d88..6555351 100644 --- a/Changelog +++ b/Changelog @@ -42,6 +42,7 @@ version : - mipsdspr1 option has been renamed to mipsdsp - aemphasis filter - mips32r5 option has bee