Re: [FFmpeg-devel] [PATCH]lavc/hevc: Support GBR encoding and decoding

2016-03-13 Thread Carl Eugen Hoyos
Hendrik Leppkes gmail.com> writes: > > Encoder and decoder patches should be separated, they are quite > > distinct code other then being related by codec, otherwise its > > probably fine. > > > > Actually some further comments: All comments applied and changes pushed. Thank you for the review

Re: [FFmpeg-devel] [PATCH]lavc/hevc: Support GBR encoding and decoding

2016-03-12 Thread Hendrik Leppkes
On Sun, Mar 13, 2016 at 3:14 AM, Hendrik Leppkes wrote: > On Sat, Mar 12, 2016 at 1:44 PM, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch allows GBR encoding and decoding for hevc. >> > > Encoder and decoder patches should be separated, they are quite > distinct code other then being related

Re: [FFmpeg-devel] [PATCH]lavc/hevc: Support GBR encoding and decoding

2016-03-12 Thread Hendrik Leppkes
On Sat, Mar 12, 2016 at 1:44 PM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch allows GBR encoding and decoding for hevc. > Encoder and decoder patches should be separated, they are quite distinct code other then being related by codec, otherwise its probably fine. - Hendrik _

Re: [FFmpeg-devel] [PATCH]lavc/hevc: Support GBR encoding and decoding

2016-03-12 Thread Carl Eugen Hoyos
Moritz Barsnick gmx.net> writes: > > +case AV_PIX_FMT_GBRP: > > +case AV_PIX_FMT_GBRP10: > > +case AV_PIX_FMT_GBRP12: > > +ctx->params->vui.matrixCoeffs = AVCOL_SPC_RGB; > > +ctx->params->vui.bEnableVideoSignalTypePresentFlag = 1; > > +ctx->params->vui.bEnable

Re: [FFmpeg-devel] [PATCH]lavc/hevc: Support GBR encoding and decoding

2016-03-12 Thread Moritz Barsnick
On Sat, Mar 12, 2016 at 13:44:13 +0100, Carl Eugen Hoyos wrote: > break; > +case AV_PIX_FMT_GBRP: > +case AV_PIX_FMT_GBRP10: > +case AV_PIX_FMT_GBRP12: > +ctx->params->vui.matrixCoeffs = AVCOL_SPC_RGB; > +ctx->params->vui.bEnableVideoSignalTypePresentFlag = 1;

Re: [FFmpeg-devel] [PATCH]lavc/hevc: Support GBR encoding and decoding

2016-03-12 Thread Carl Eugen Hoyos
Carl Eugen Hoyos ag.or.at> writes: > AV_PIX_FMT_YUV420P, > AV_PIX_FMT_YUV422P, > AV_PIX_FMT_YUV444P, > +AV_PIX_FMT_GBRP10, Fixed locally to AV_PIX_FMT_GBRP; Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ff

[FFmpeg-devel] [PATCH]lavc/hevc: Support GBR encoding and decoding

2016-03-12 Thread Carl Eugen Hoyos
Hi! Attached patch allows GBR encoding and decoding for hevc. Please comment, Carl Eugen diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c index bcb63a3..7237ee6 100644 --- a/libavcodec/hevc_ps.c +++ b/libavcodec/hevc_ps.c @@ -561,6 +561,17 @@ static void decode_vui(GetBitContext *gb, AVCo