Re: [FFmpeg-devel] [PATCH]lavc/h264:Only check x264_build if it was set

2017-10-06 Thread Michael Niedermayer
On Fri, Oct 06, 2017 at 08:19:43PM +0200, Carl Eugen Hoyos wrote: > 2017-10-06 18:54 GMT+02:00 Henrik Gramner : > > On Thu, Oct 5, 2017 at 8:31 AM, Carl Eugen Hoyos wrote: > >> Hi! > >> > >> Attached patch fixes ticket #6717. > >> > >> Please comment, Carl Eugen > > > > Signed numbers are converte

Re: [FFmpeg-devel] [PATCH]lavc/h264:Only check x264_build if it was set

2017-10-06 Thread Carl Eugen Hoyos
2017-10-06 18:54 GMT+02:00 Henrik Gramner : > On Thu, Oct 5, 2017 at 8:31 AM, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes ticket #6717. >> >> Please comment, Carl Eugen > > Signed numbers are converted to unsigned when compared to unsigned > numbers which means -1 becomes UINT_MAX so

Re: [FFmpeg-devel] [PATCH]lavc/h264:Only check x264_build if it was set

2017-10-06 Thread Hendrik Leppkes
On Fri, Oct 6, 2017 at 6:54 PM, Henrik Gramner wrote: > On Thu, Oct 5, 2017 at 8:31 AM, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes ticket #6717. >> >> Please comment, Carl Eugen > > Signed numbers are converted to unsigned when compared to unsigned > numbers which means -1 becomes

Re: [FFmpeg-devel] [PATCH]lavc/h264:Only check x264_build if it was set

2017-10-06 Thread Henrik Gramner
On Thu, Oct 5, 2017 at 8:31 AM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #6717. > > Please comment, Carl Eugen Signed numbers are converted to unsigned when compared to unsigned numbers which means -1 becomes UINT_MAX so this patch shouldn't actually change anything. #6717 i

Re: [FFmpeg-devel] [PATCH]lavc/h264:Only check x264_build if it was set

2017-10-05 Thread Michael Niedermayer
On Thu, Oct 05, 2017 at 08:31:39AM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #6717. > > Please comment, Carl Eugen > h264_cabac.c |2 +- > h264_mb.c|2 +- > h264_slice.c |2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > 9e712a4dbc032aa844d869

[FFmpeg-devel] [PATCH]lavc/h264:Only check x264_build if it was set

2017-10-04 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #6717. Please comment, Carl Eugen From 3315fa024958246685b2431c2605e867f651ad5b Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 5 Oct 2017 08:29:27 +0200 Subject: [PATCH] lavc/h264: Only check x264_build if it was set. Fixes ticket #6718. --- libavcod