Paul B Mahol gmail.com> writes:
> >> do you have explanation why it should change?
> >
> > Because I believe it is wrong.
> Should be ok, but keep postproc step for case when
> y and a are swapped.
Done and pushed, thanks for spotting this.
Thank you, Carl Eugen
_
On 4/14/16, Carl Eugen Hoyos wrote:
> Paul B Mahol gmail.com> writes:
>
>> > +else if (bpp == 16 && r == 0xff00 && g == 0 &&
>> b == 0 && a == 0xff) {
>> > +avctx->pix_fmt = AV_PIX_FMT_YA8;
>> > +ctx->postproc = DDS_SWAP_ALPHA;
>>
>> Why? You disabled postproc line
Paul B Mahol gmail.com> writes:
> > +else if (bpp == 16 && r == 0xff00 && g == 0 &&
> b == 0 && a == 0xff) {
> > +avctx->pix_fmt = AV_PIX_FMT_YA8;
> > +ctx->postproc = DDS_SWAP_ALPHA;
>
> Why? You disabled postproc lines bellow.
I don't understand this comment:
On 4/14/16, Carl Eugen Hoyos wrote:
> Hi!
>
> Attached patch fixes the original sample of ticket #4667 for me.
>
> Please comment, Carl Eugen
>
> diff --git a/libavcodec/dds.c b/libavcodec/dds.c
> index 9577b67..f364de7 100644
> --- a/libavcodec/dds.c
> +++ b/libavcodec/dds.c
> @@ -356,6 +356,10
Hi!
Attached patch fixes the original sample of ticket #4667 for me.
Please comment, Carl Eugen
diff --git a/libavcodec/dds.c b/libavcodec/dds.c
index 9577b67..f364de7 100644
--- a/libavcodec/dds.c
+++ b/libavcodec/dds.c
@@ -356,6 +356,10 @@ static int parse_pixel_format(AVCodecContext *avctx)
