Re: [FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

2017-02-12 Thread wm4
On Sun, 12 Feb 2017 16:52:21 +0100 wm4 wrote: > On Sun, 12 Feb 2017 16:48:57 +0100 > Carl Eugen Hoyos wrote: > > > Hi! > > > > Attached patch written yesterday silences warnings when compiling > > ffmpeg.c, don't know how useful it is, only fate-tested. > > > > Please comment, Carl Eugen >

Re: [FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

2017-02-12 Thread Paul B Mahol
On 2/12/17, Nicolas George wrote: > Le quartidi 24 pluviose, an CCXXV, Carl Eugen Hoyos a ecrit : >> New patch attached, Carl Eugen > > Thanks. The new patch looks fine to me, of course. > > I have said my piece on the other considerations, I do not think the > eventual decision is mine to make. >

Re: [FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

2017-02-12 Thread Nicolas George
Le quartidi 24 pluviôse, an CCXXV, Carl Eugen Hoyos a écrit : > New patch attached, Carl Eugen Thanks. The new patch looks fine to me, of course. I have said my piece on the other considerations, I do not think the eventual decision is mine to make. Regards, -- Nicolas George signature.asc

Re: [FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

2017-02-12 Thread Carl Eugen Hoyos
2017-02-12 17:12 GMT+01:00 Marton Balint : > > On Sun, 12 Feb 2017, Carl Eugen Hoyos wrote: > >> Attached patch written yesterday silences warnings when compiling >> ffmpeg.c, don't know how useful it is, only fate-tested. > > Writing a warning about the failed filter functions is good, but ffmpeg

Re: [FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

2017-02-12 Thread Carl Eugen Hoyos
2017-02-12 17:00 GMT+01:00 Nicolas George : > Le quartidi 24 pluviôse, an CCXXV, Carl Eugen Hoyos a écrit : >> Hi! >> >> Attached patch written yesterday silences warnings when compiling >> ffmpeg.c, don't know how useful it is, only fate-tested. >> >> Please comment, Carl Eugen > >> From 525aff909

Re: [FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

2017-02-12 Thread Nicolas George
Le quartidi 24 pluviôse, an CCXXV, Marton Balint a écrit : > Writing a warning about the failed filter functions is good, but ffmpeg has > a -xerror option as well, so I guess the proper fix would be to propagate > the error through the functions and fail the encoding process as well if > -xerror i

Re: [FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

2017-02-12 Thread Marton Balint
On Sun, 12 Feb 2017, Carl Eugen Hoyos wrote: Hi! Attached patch written yesterday silences warnings when compiling ffmpeg.c, don't know how useful it is, only fate-tested. Writing a warning about the failed filter functions is good, but ffmpeg has a -xerror option as well, so I guess the pr

Re: [FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

2017-02-12 Thread Nicolas George
Le quartidi 24 pluviôse, an CCXXV, Carl Eugen Hoyos a écrit : > Hi! > > Attached patch written yesterday silences warnings when compiling > ffmpeg.c, don't know how useful it is, only fate-tested. > > Please comment, Carl Eugen > From 525aff909aec50d4e1a49f289ff9069300a4b51f Mon Sep 17 00:00:00

Re: [FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

2017-02-12 Thread wm4
On Sun, 12 Feb 2017 16:48:57 +0100 Carl Eugen Hoyos wrote: > Hi! > > Attached patch written yesterday silences warnings when compiling > ffmpeg.c, don't know how useful it is, only fate-tested. > > Please comment, Carl Eugen Conflicts with my merge patches. ___

[FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

2017-02-12 Thread Carl Eugen Hoyos
Hi! Attached patch written yesterday silences warnings when compiling ffmpeg.c, don't know how useful it is, only fate-tested. Please comment, Carl Eugen From 525aff909aec50d4e1a49f289ff9069300a4b51f Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 12 Feb 2017 16:41:21 +0100 Subject: