Re: [FFmpeg-devel] [PATCH]Support linebreaks in onCaption subtitles

2015-05-04 Thread wm4
On Mon, 4 May 2015 10:15:54 + (UTC) Carl Eugen Hoyos wrote: > Clément Bœsch pkh.me> writes: > > > > Carl Eugen Hoyos ag.or.at> writes: > > > > > > > Clément Bœsch pkh.me> writes: > > > > > > > > > > +text->linebreaks = ""; > > > > > > > > > > i'm afraid this won't be enough to supp

Re: [FFmpeg-devel] [PATCH]Support linebreaks in onCaption subtitles

2015-05-04 Thread Michael Niedermayer
On Mon, May 04, 2015 at 11:48:04AM +0200, Clément Bœsch wrote: > On Mon, May 04, 2015 at 09:41:35AM +, Carl Eugen Hoyos wrote: > > Carl Eugen Hoyos ag.or.at> writes: > > > > > Clément Bœsch pkh.me> writes: > > > > > > > > +text->linebreaks = ""; > > > > > > > > i'm afraid this won't be

Re: [FFmpeg-devel] [PATCH]Support linebreaks in onCaption subtitles

2015-05-04 Thread Carl Eugen Hoyos
Clément Bœsch pkh.me> writes: > > Carl Eugen Hoyos ag.or.at> writes: > > > > > Clément Bœsch pkh.me> writes: > > > > > > > > +text->linebreaks = ""; > > > > > > > > i'm afraid this won't be enough to support > > > > "", "", "", ... > > > > > > I only looked at the sample we have, are t

Re: [FFmpeg-devel] [PATCH]Support linebreaks in onCaption subtitles

2015-05-04 Thread Clément Bœsch
On Mon, May 04, 2015 at 09:41:35AM +, Carl Eugen Hoyos wrote: > Carl Eugen Hoyos ag.or.at> writes: > > > Clément Bœsch pkh.me> writes: > > > > > > +text->linebreaks = ""; > > > > > > i'm afraid this won't be enough to support > > > "", "", "", ... > > > > I only looked at the sample

Re: [FFmpeg-devel] [PATCH]Support linebreaks in onCaption subtitles

2015-05-04 Thread Carl Eugen Hoyos
Carl Eugen Hoyos ag.or.at> writes: > Clément Bœsch pkh.me> writes: > > > > +text->linebreaks = ""; > > > > i'm afraid this won't be enough to support > > "", "", "", ... > > I only looked at the sample we have, are they > all valid line breaks? Ping, I don't understand your comment. C

Re: [FFmpeg-devel] [PATCH]Support linebreaks in onCaption subtitles

2015-05-01 Thread Carl Eugen Hoyos
Clément Bœsch pkh.me> writes: > > +text->linebreaks = ""; > > i'm afraid this won't be enough to support > "", "", "", ... I only looked at the sample we have, are they all valid line breaks? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-deve

Re: [FFmpeg-devel] [PATCH]Support linebreaks in onCaption subtitles

2015-05-01 Thread Clément Bœsch
On Fri, May 01, 2015 at 01:48:34AM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch improves the samples from ticket #2933. > > Please comment, Carl Eugen > diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c > index 2552962..9bd69c5 100644 > --- a/libavcodec/allcodecs.c > +++ b/

Re: [FFmpeg-devel] [PATCH]Support linebreaks in onCaption subtitles

2015-05-01 Thread Carl Eugen Hoyos
Carl Eugen Hoyos ag.or.at> writes: > Attached patch improves the samples from ticket #2933. Version bump and Makefile entry locally added. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-deve

[FFmpeg-devel] [PATCH]Support linebreaks in onCaption subtitles

2015-04-30 Thread Carl Eugen Hoyos
Hi! Attached patch improves the samples from ticket #2933. Please comment, Carl Eugen diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c index 2552962..9bd69c5 100644 --- a/libavcodec/allcodecs.c +++ b/libavcodec/allcodecs.c @@ -500,6 +500,7 @@ void avcodec_register_all(void) REGIS