Re: [FFmpeg-devel] [PATCH]Only run the tta crc checks if requested

2015-02-06 Thread Carl Eugen Hoyos
James Almer gmail.com> writes: > This is skipping avio_rl32() and not updating > the pb pointer when crc is not checked Sorry, please ignore. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-

Re: [FFmpeg-devel] [PATCH]Only run the tta crc checks if requested

2015-02-06 Thread James Almer
On 06/02/15 6:15 AM, Carl Eugen Hoyos wrote: > -crc = ffio_get_checksum(s->pb) ^ UINT32_MAX; > -if (crc != avio_rl32(s->pb) && s->error_recognition & AV_EF_CRCCHECK) { > -av_log(s, AV_LOG_ERROR, "Header CRC error\n"); > -return AVERROR_INVALIDDATA; > +if (s->error_recogn

Re: [FFmpeg-devel] [PATCH]Only run the tta crc checks if requested

2015-02-06 Thread Paul B Mahol
On 2/6/15, Carl Eugen Hoyos wrote: > Hi! > > I did not benchmark but attached should be both a little faster > and a little cleaner. > > Please comment, Carl Eugen > > From 8bf4e1c82e818483a5bbf55147bb818e5cfacc70 Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos > Date: Fri, 6 Feb 2015 10:13:31

[FFmpeg-devel] [PATCH]Only run the tta crc checks if requested

2015-02-06 Thread Carl Eugen Hoyos
Hi! I did not benchmark but attached should be both a little faster and a little cleaner. Please comment, Carl Eugen From 8bf4e1c82e818483a5bbf55147bb818e5cfacc70 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 6 Feb 2015 10:13:31 +0100 Subject: [PATCH] avformat/tta: only check for h