Re: [FFmpeg-devel] [PATCH]Fix leak reading invalid mxf files

2014-12-14 Thread Carl Eugen Hoyos
Tomas Härdin codemill.se> writes: > > New patch attached that also fixes the remaining > > leaks from ticket #4173. > > I would split in two parts, please tell me if > > you prefer more separate commits. > > Eh, it's small enough that it's clear what the > patch does. The patch was merged by

Re: [FFmpeg-devel] [PATCH]Fix leak reading invalid mxf files

2014-12-14 Thread Tomas Härdin
On Sat, 2014-12-13 at 13:18 +0100, Carl Eugen Hoyos wrote: > On Friday 12 December 2014 01:43:19 pm Tomas Härdin wrote: > > On Wed, 2014-12-10 at 11:30 +0100, Carl Eugen Hoyos wrote: > > > Hi! > > > > > > Attached patch fixes ticket #4173 for me. > > > To be split in two parts. > > > > > > Please c

Re: [FFmpeg-devel] [PATCH]Fix leak reading invalid mxf files

2014-12-13 Thread Carl Eugen Hoyos
On Friday 12 December 2014 01:43:19 pm Tomas Härdin wrote: > On Wed, 2014-12-10 at 11:30 +0100, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes ticket #4173 for me. > > To be split in two parts. > > > > Please comment, Carl Eugen > > Looks alright. Maybe you want to pass it a MXFMetada

Re: [FFmpeg-devel] [PATCH]Fix leak reading invalid mxf files

2014-12-12 Thread Tomas Härdin
On Wed, 2014-12-10 at 11:30 +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #4173 for me. > To be split in two parts. > > Please comment, Carl Eugen Looks alright. Maybe you want to pass it a MXFMetadataSet** so you can use av_freep() like before? But I suppose it doesn't ma

Re: [FFmpeg-devel] [PATCH]Fix leak reading invalid mxf files

2014-12-12 Thread Michael Niedermayer
On Wed, Dec 10, 2014 at 11:30:54AM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #4173 for me. > To be split in two parts. > > Please comment, Carl Eugen probably ok if tomas doesnt reply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

[FFmpeg-devel] [PATCH]Fix leak reading invalid mxf files

2014-12-10 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #4173 for me. To be split in two parts. Please comment, Carl Eugen diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 6c104b9..3cf2bd4 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -282,6 +282,38 @@ static const uint8_t mxf_sony_mpeg4_