Re: [FFmpeg-devel] [PATCH]Do not list mov codecs in riff.c

2015-03-13 Thread compn
On Fri, 13 Mar 2015 10:11:47 +0100 wm4 wrote: > Nice warning, but why do we accept this in the first place? This looks > so very wrong. suggestions are welcome. 1) refuse all "invalid" files 2) duplicate all riff/isom lists 3) do this instead maybe people use old software or run into crashes i

Re: [FFmpeg-devel] [PATCH]Do not list mov codecs in riff.c

2015-03-13 Thread Carl Eugen Hoyos
wm4 googlemail.com> writes: > > +if (!st->codec->codec_id) { > > +st->codec->codec_id = ff_codec_get_id(ff_codec_movvideo_tags, > > + tag1); > > +if (st->codec->codec_id) > > +av_log(s, AV_LOG_WARNING, "mov tag found in

Re: [FFmpeg-devel] [PATCH]Do not list mov codecs in riff.c

2015-03-13 Thread wm4
On Fri, 13 Mar 2015 02:46:32 +0100 Carl Eugen Hoyos wrote: > diff --git a/libavformat/avidec.c b/libavformat/avidec.c > index 5c9443a..00f0037 100644 > --- a/libavformat/avidec.c > +++ b/libavformat/avidec.c > @@ -36,6 +36,7 @@ > #include "riff.h" > #include "libavcodec/bytestream.h" > #includ

Re: [FFmpeg-devel] [PATCH]Do not list mov codecs in riff.c

2015-03-13 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > > avidec.c |7 +++ > > riff.c |3 --- > > 2 files changed, 7 insertions(+), 3 deletions(-) > > 7c301d00fc64be53584b4f6a2f54461bb85447e7 patchproresavi.diff > > diff --git a/libavformat/avidec.c b/libavformat/avidec.c > > index 5c9443a..00f0037

Re: [FFmpeg-devel] [PATCH]Do not list mov codecs in riff.c

2015-03-12 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 02:46:32AM +0100, Carl Eugen Hoyos wrote: > On Friday 13 March 2015 02:36:00 am Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes a regression caused by randomly added > > prores code-points in riff.c (similar to ticket #4307). As > > a side-effect, it shows a war

Re: [FFmpeg-devel] [PATCH]Do not list mov codecs in riff.c

2015-03-12 Thread Carl Eugen Hoyos
On Friday 13 March 2015 02:36:00 am Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes a regression caused by randomly added > prores code-points in riff.c (similar to ticket #4307). As > a side-effect, it shows a warning for such (probably > invalid) files). Updated patch attached. Carl Euge

[FFmpeg-devel] [PATCH]Do not list mov codecs in riff.c

2015-03-12 Thread Carl Eugen Hoyos
Hi! Attached patch fixes a regression caused by randomly added prores code-points in riff.c (similar to ticket #4307). As a side-effect, it shows a warning for such (probably invalid) files). Please comment, Carl Eugen diff --git a/libavformat/avidec.c b/libavformat/avidec.c index 5c9443a..00f