Re: [FFmpeg-devel] [PATCH]Allow easy png streamcopying

2015-05-04 Thread Carl Eugen Hoyos
Carl Eugen Hoyos ag.or.at> writes: > On Thursday 23 April 2015 03:05:48 pm Michael Niedermayer wrote: > > without really thinking about it, the idea to remove the extension > > for apng or change it to .apng, seems like a good idea > > New patch attached. This variant was merged. Carl Eugen _

Re: [FFmpeg-devel] [PATCH]Allow easy png streamcopying

2015-04-30 Thread tim nicholson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 27/04/15 13:16, Nicolas George wrote: > L'octidi 8 floréal, an CCXXIII, Michael Niedermayer a écrit : >> the code changes look ok > > The phrasing seems to invite this: > > The commit message does not shock me. > > Seriously, I do not know how my

Re: [FFmpeg-devel] [PATCH]Allow easy png streamcopying

2015-04-27 Thread Nicolas George
L'octidi 8 floréal, an CCXXIII, Michael Niedermayer a écrit : > the code changes look ok The phrasing seems to invite this: The commit message does not shock me. Seriously, I do not know how my message about commit messages ended being so long, I do not intend to become a commit message tyrant,

Re: [FFmpeg-devel] [PATCH]Allow easy png streamcopying

2015-04-27 Thread Michael Niedermayer
On Mon, Apr 27, 2015 at 10:13:59AM +0200, Carl Eugen Hoyos wrote: > On Thursday 23 April 2015 03:05:48 pm Michael Niedermayer wrote: > > without really thinking about it, the idea to remove the extension > > for apng or change it to .apng, seems like a good idea > > New patch attached. > > Please

Re: [FFmpeg-devel] [PATCH]Allow easy png streamcopying

2015-04-27 Thread Carl Eugen Hoyos
On Thursday 23 April 2015 03:05:48 pm Michael Niedermayer wrote: > without really thinking about it, the idea to remove the extension > for apng or change it to .apng, seems like a good idea New patch attached. Please comment, Carl Eugen From 56b8fa753399c53d83231bc56b7461ccaeb62de3 Mon Sep 17 00

Re: [FFmpeg-devel] [PATCH]Allow easy png streamcopying

2015-04-23 Thread Donny Yang
On 23 April 2015 at 23:38, Nicolas George wrote: > Le quartidi 4 floréal, an CCXXIII, Michael Niedermayer a écrit : > > without really thinking about it, the idea to remove the extension > > for apng or change it to .apng, seems like a good idea > > It looks like it is an officially supported ext

Re: [FFmpeg-devel] [PATCH]Allow easy png streamcopying

2015-04-23 Thread Nicolas George
Le quartidi 4 floréal, an CCXXIII, Michael Niedermayer a écrit : > without really thinking about it, the idea to remove the extension > for apng or change it to .apng, seems like a good idea It looks like it is an officially supported extension, and having the same extension for two not-really-com

Re: [FFmpeg-devel] [PATCH]Allow easy png streamcopying

2015-04-23 Thread Michael Niedermayer
On Thu, Apr 23, 2015 at 12:14:43PM +, Carl Eugen Hoyos wrote: > wm4 googlemail.com> writes: > > > > Stream-copying png is currently too difficult. > > > An alternative is to remove the extension from the > > > apng muxer. > > > > > > Please comment, Carl Eugen > > > > I don't understand wh

Re: [FFmpeg-devel] [PATCH]Allow easy png streamcopying

2015-04-23 Thread Carl Eugen Hoyos
wm4 googlemail.com> writes: > > Stream-copying png is currently too difficult. > > An alternative is to remove the extension from the > > apng muxer. > > > > Please comment, Carl Eugen > > I don't understand why apng would use the png file > extension. As said, removing the extension is also

Re: [FFmpeg-devel] [PATCH]Allow easy png streamcopying

2015-04-23 Thread wm4
On Thu, 23 Apr 2015 09:25:44 +0200 Carl Eugen Hoyos wrote: > Hi! > > Stream-copying png is currently too difficult. > An alternative is to remove the extension from the apng muxer. > > Please comment, Carl Eugen I don't understand why apng would use the png file extension. This makes it way to

Re: [FFmpeg-devel] [PATCH]Allow easy png streamcopying

2015-04-23 Thread Carl Eugen Hoyos
Nicolas George nsup.org> writes: > > Stream-copying png is currently too difficult. > > I can not comment on the patch itself, but the > commit message should explain what the patch does, > not just why it was needed. I believe it is much more important to explain why. [...] > Maybe somethi

Re: [FFmpeg-devel] [PATCH]Allow easy png streamcopying

2015-04-23 Thread Nicolas George
Le quartidi 4 floréal, an CCXXIII, Carl Eugen Hoyos a écrit : > Subject: [FFmpeg-devel] [PATCH]Allow easy png streamcopying > > Stream-copying png is currently too difficult. I can not comment on the patch itself, but the commit message should explain what the patch does, not just w

[FFmpeg-devel] [PATCH]Allow easy png streamcopying

2015-04-23 Thread Carl Eugen Hoyos
Hi! Stream-copying png is currently too difficult. An alternative is to remove the extension from the apng muxer. Please comment, Carl Eugen diff --git a/libavformat/apngenc.c b/libavformat/apngenc.c index 4b31309..9090f92 100644 --- a/libavformat/apngenc.c +++ b/libavformat/apngenc.c @@ -23,6 +2