Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-04-01 Thread Ronald S. Bultje
Hi, On Fri, Apr 1, 2016 at 4:57 AM, Disha Singh wrote: > Somehow I am not getting these warnings when I compile. (not all) OK, so we should stop here and fix this. Why is the encoder not being compiled for you? This back-and-forth on compiler warnings/errors is ridiculous. Please figure out ho

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-04-01 Thread Michael Niedermayer
On Fri, Apr 01, 2016 at 02:27:43PM +0530, Disha Singh wrote: > Somehow I am not getting these warnings when I compile. (not all) > Should I remove the functions which are defined but not used. They may be > needed sometime later. > I have removed the error in line 1888. theres now an error in line

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-04-01 Thread Disha Singh
Somehow I am not getting these warnings when I compile. (not all) Should I remove the functions which are defined but not used. They may be needed sometime later. I have removed the error in line 1888. I do not get any error in line 2462. What should I add in my code that the compiler you used does

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-29 Thread Michael Niedermayer
On Wed, Mar 30, 2016 at 06:38:33AM +0530, Disha Singh wrote: > The most recent patch has been attached. The lpc error persists. > I have removed some patcheck errors. > [...] > +/ > + *** Functions that proce

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-29 Thread Disha Singh
The most recent patch has been attached. The lpc error persists. I have removed some patcheck errors. -Disha On Tue, Mar 29, 2016 at 6:24 AM, Michael Niedermayer wrote: > On Tue, Mar 29, 2016 at 03:13:50AM +0530, Disha Singh wrote: > > What is lpc ? > > linear predictive coding > > > > Which lp

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-28 Thread Michael Niedermayer
On Tue, Mar 29, 2016 at 03:13:50AM +0530, Disha Singh wrote: > What is lpc ? linear predictive coding > Which lpc type (there are many in libavcodec/lpc.h)should be > used for mlp ? i would guess that doesnt matter and it should at some point become a user specified parameter you can also look

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-28 Thread Disha Singh
To correct that : the error is in line 214 in lpc.c not lpc.h On Tue, Mar 29, 2016 at 3:13 AM, Disha Singh wrote: > What is lpc ? Which lpc type (there are many in libavcodec/lpc.h)should be > used for mlp ? Also, please tell lpc_passes and precision and max_order > value to be specified for mlp

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-28 Thread Disha Singh
What is lpc ? Which lpc type (there are many in libavcodec/lpc.h)should be used for mlp ? Also, please tell lpc_passes and precision and max_order value to be specified for mlp. In correct order of parameters in old file is causing SIGABRT error in line 214 in lpc.h . :((( On Mon, Mar 28, 2016 at

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-27 Thread Michael Niedermayer
On Sun, Mar 27, 2016 at 11:01:11AM +0530, Disha Singh wrote: > > testing this > > ./ffmpeg -i in.m4a test.mlp > > says it needs 'To use it anyways, you must set "-strict inofficial".' > > thats ok if it would work: > > > > ./ffmpeg -i in.m4a -strict inofficial test.mlp > > [mlp @ 0x2494740] Unable

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-26 Thread Disha Singh
> testing this > ./ffmpeg -i in.m4a test.mlp > says it needs 'To use it anyways, you must set "-strict inofficial".' > thats ok if it would work: > > ./ffmpeg -i in.m4a -strict inofficial test.mlp > [mlp @ 0x2494740] Unable to parse option value "inofficial" > > Using :ffmpeg -i ~/input.mp3 -stric

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-26 Thread Michael Niedermayer
On Sat, Mar 26, 2016 at 10:18:47PM +0530, Disha Singh wrote: > This is the revised patch created using git format-patch. > > -Disha > > On Thu, Mar 24, 2016 at 2:45 PM, Paul B Mahol wrote: > > > On 3/21/16, Disha Singh wrote: > > > Qualification task for project TrueHD encoder. > > > There are

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-26 Thread Michael Niedermayer
On Sun, Mar 27, 2016 at 04:55:36AM +0530, Disha Singh wrote: > Just running ./patcheck would do? you have to feed the patch to be checked on stdin as in cat mypatch | ./patcheck [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are too smart to engage in

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-26 Thread Disha Singh
Just running ./patcheck would do? On Sun, Mar 27, 2016 at 12:50 AM, Lou Logan wrote: > On Sat, 26 Mar 2016 22:18:47 +0530, Disha Singh wrote: > > > From 639aa2a07be6064049b2ba1e134e1474cb7f0806 Mon Sep 17 00:00:00 2001 > > From: dinux5 > > Date: Sat, 26 Mar 2016 22:11:59 +0530 > > Subject: [PAT

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-26 Thread Lou Logan
On Sat, 26 Mar 2016 22:18:47 +0530, Disha Singh wrote: > From 639aa2a07be6064049b2ba1e134e1474cb7f0806 Mon Sep 17 00:00:00 2001 > From: dinux5 > Date: Sat, 26 Mar 2016 22:11:59 +0530 > Subject: [PATCH] Mlp encoder addition. > > --- > configure |1 + > libavcodec/Makefile|

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-26 Thread Disha Singh
This is the revised patch created using git format-patch. -Disha On Thu, Mar 24, 2016 at 2:45 PM, Paul B Mahol wrote: > On 3/21/16, Disha Singh wrote: > > Qualification task for project TrueHD encoder. > > There are two patches. > > One has the changes made to other files to support mlpenc.c a

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-24 Thread Paul B Mahol
On 3/21/16, Disha Singh wrote: > Qualification task for project TrueHD encoder. > There are two patches. > One has the changes made to other files to support mlpenc.c and the other > only has mlpenc.c. > Also attached is the diff file of mlpenc.c. > (Modified the file : > https://github.com/ramiro

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-23 Thread Disha Singh
This is the modified diff with few changes in mlp_encode_frame function. -Disha On Tue, Mar 22, 2016 at 1:59 AM, Disha Singh wrote: > Qualification task for project TrueHD encoder. > There are two patches. > One has the changes made to other files to support mlpenc.c and the other > only has ml

[FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-21 Thread Disha Singh
Qualification task for project TrueHD encoder. There are two patches. One has the changes made to other files to support mlpenc.c and the other only has mlpenc.c. Also attached is the diff file of mlpenc.c. (Modified the file : https://github.com/ramiropolla/soc/blob/master/mlp/mlpenc.c) diff --git