Re: [FFmpeg-devel] [PATCH] x86: vc1dsp: Convert vc1_inv_trans_*_dc to NASM format

2016-02-01 Thread Timothy Gu
On Mon, Feb 01, 2016 at 01:26:37AM +0100, Michael Niedermayer wrote: > > breaks on x86-32 it seems > > vcodec/x86/vp9dsp_init_12bpp.o > CC libavcodec/x86/vp9dsp_init_16bpp.o > STRIP libavcodec/x86/qpeldsp.o > src/libavcodec/x86/vc1dsp.asm:444: error: invalid combination of opcode and > op

Re: [FFmpeg-devel] [PATCH] x86: vc1dsp: Convert vc1_inv_trans_*_dc to NASM format

2016-02-01 Thread Ronald S. Bultje
Hi, On Mon, Feb 1, 2016 at 11:53 AM, Timothy Gu wrote: > On Sun, Jan 31, 2016 at 4:19 PM Ronald S. Bultje > wrote: > > > > I wanted to do that at first, but then I realized that to change this > I'd > > > need > > > to change simple_idct and a bunch of other decoders. > > > > > > Wait, what? Ho

Re: [FFmpeg-devel] [PATCH] x86: vc1dsp: Convert vc1_inv_trans_*_dc to NASM format

2016-02-01 Thread Timothy Gu
On Sun, Jan 31, 2016 at 4:19 PM Ronald S. Bultje wrote: > > I wanted to do that at first, but then I realized that to change this I'd > > need > > to change simple_idct and a bunch of other decoders. > > > Wait, what? How? Isn't this vc1-only code? > https://github.com/FFmpeg/FFmpeg/blob/235381e

Re: [FFmpeg-devel] [PATCH] x86: vc1dsp: Convert vc1_inv_trans_*_dc to NASM format

2016-01-31 Thread James Almer
On 1/31/2016 8:28 PM, Timothy Gu wrote: > --- > libavcodec/x86/vc1dsp.asm| 98 > libavcodec/x86/vc1dsp_init.c | 13 +++ > libavcodec/x86/vc1dsp_mmx.c | 207 > --- > 3 files changed, 111 insertions(+), 207 deletions(-) > > diff -

Re: [FFmpeg-devel] [PATCH] x86: vc1dsp: Convert vc1_inv_trans_*_dc to NASM format

2016-01-31 Thread Michael Niedermayer
On Sun, Jan 31, 2016 at 03:28:40PM -0800, Timothy Gu wrote: > --- > libavcodec/x86/vc1dsp.asm| 98 > libavcodec/x86/vc1dsp_init.c | 13 +++ > libavcodec/x86/vc1dsp_mmx.c | 207 > --- > 3 files changed, 111 insertions(+), 207 dele

Re: [FFmpeg-devel] [PATCH] x86: vc1dsp: Convert vc1_inv_trans_*_dc to NASM format

2016-01-31 Thread Ronald S. Bultje
Hi, On Sun, Jan 31, 2016 at 6:27 PM, Timothy Gu wrote: > On Sun, Jan 31, 2016 at 06:18:53PM -0300, James Almer wrote: > > On 1/31/2016 4:48 PM, Timothy Gu wrote: > > > --- > > > libavcodec/x86/vc1dsp.asm| 104 ++ > > > libavcodec/x86/vc1dsp_init.c | 13 +++ > > > libavc

[FFmpeg-devel] [PATCH] x86: vc1dsp: Convert vc1_inv_trans_*_dc to NASM format

2016-01-31 Thread Timothy Gu
--- libavcodec/x86/vc1dsp.asm| 98 libavcodec/x86/vc1dsp_init.c | 13 +++ libavcodec/x86/vc1dsp_mmx.c | 207 --- 3 files changed, 111 insertions(+), 207 deletions(-) diff --git a/libavcodec/x86/vc1dsp.asm b/libavcodec/x86/vc1dsp.

Re: [FFmpeg-devel] [PATCH] x86: vc1dsp: Convert vc1_inv_trans_*_dc to NASM format

2016-01-31 Thread Timothy Gu
On Sun, Jan 31, 2016 at 06:18:53PM -0300, James Almer wrote: > On 1/31/2016 4:48 PM, Timothy Gu wrote: > > --- > > libavcodec/x86/vc1dsp.asm| 104 ++ > > libavcodec/x86/vc1dsp_init.c | 13 +++ > > libavcodec/x86/vc1dsp_mmx.c | 207 > >

Re: [FFmpeg-devel] [PATCH] x86: vc1dsp: Convert vc1_inv_trans_*_dc to NASM format

2016-01-31 Thread Henrik Gramner
On Sun, Jan 31, 2016 at 10:18 PM, James Almer wrote: > On 1/31/2016 4:48 PM, Timothy Gu wrote: >> +; ff_vc1_inv_trans_?x?_dc_mmxext(uint8_t *dest, int linesize, int16_t >> *block) >> +INIT_MMX mmxext >> +cglobal vc1_inv_trans_4x4_dc, 3,4,0, dest, linesize, block >> +movsx r3d, WORD [b

Re: [FFmpeg-devel] [PATCH] x86: vc1dsp: Convert vc1_inv_trans_*_dc to NASM format

2016-01-31 Thread James Almer
On 1/31/2016 6:18 PM, James Almer wrote: > On 1/31/2016 4:48 PM, Timothy Gu wrote: >> +; ff_vc1_inv_trans_?x?_dc_mmxext(uint8_t *dest, int linesize, int16_t >> *block) >> +INIT_MMX mmxext >> +cglobal vc1_inv_trans_4x4_dc, 3,4,0, dest, linesize, block >> +movsx r3d, WORD [blockq] > > C

Re: [FFmpeg-devel] [PATCH] x86: vc1dsp: Convert vc1_inv_trans_*_dc to NASM format

2016-01-31 Thread James Almer
On 1/31/2016 4:48 PM, Timothy Gu wrote: > --- > libavcodec/x86/vc1dsp.asm| 104 ++ > libavcodec/x86/vc1dsp_init.c | 13 +++ > libavcodec/x86/vc1dsp_mmx.c | 207 > --- > 3 files changed, 117 insertions(+), 207 deletions(-) > > diff

Re: [FFmpeg-devel] [PATCH] x86: vc1dsp: Convert vc1_inv_trans_*_dc to NASM format

2016-01-31 Thread Ronald S. Bultje
Hi, On Sun, Jan 31, 2016 at 2:48 PM, Timothy Gu wrote: > +; ff_vc1_inv_trans_?x?_dc_mmxext(uint8_t *dest, int linesize, int16_t > *block) +INIT_MMX mmxext > +cglobal vc1_inv_trans_4x4_dc, 3,4,0, dest, linesize, block > [..] > +%define linesize3q r2q > DEFINE_ARGS dest, linesize, linesize3 Re

[FFmpeg-devel] [PATCH] x86: vc1dsp: Convert vc1_inv_trans_*_dc to NASM format

2016-01-31 Thread Timothy Gu
--- libavcodec/x86/vc1dsp.asm| 104 ++ libavcodec/x86/vc1dsp_init.c | 13 +++ libavcodec/x86/vc1dsp_mmx.c | 207 --- 3 files changed, 117 insertions(+), 207 deletions(-) diff --git a/libavcodec/x86/vc1dsp.asm b/libavcodec/x86/vc1ds