Re: [FFmpeg-devel] [PATCH] x86/hevc_sao: fix loading of RIP address

2015-02-06 Thread James Almer
On 06/02/15 2:10 PM, Christophe Gisquet wrote: > The new common loading block could almost be abstracted in a single > macro (with the stride as parameter). > > Something like: > %macro LOAD_EO_ARGS 1 > %define tmp2q heightq > %if WIN64 > movsxd eoq, dword r4m > %else > movsxd

Re: [FFmpeg-devel] [PATCH] x86/hevc_sao: fix loading of RIP address

2015-02-06 Thread James Almer
On 06/02/15 2:13 PM, Hendrik Leppkes wrote: > On Fri, Feb 6, 2015 at 6:10 PM, Christophe Gisquet > wrote: >> Hi, >> >> 2015-02-06 17:54 GMT+01:00 James Almer : >>> pb_eo must be handled as a rip relative address for MSVC64, so an >>> intermediate register is needed. Should fix link failures. >> >>

Re: [FFmpeg-devel] [PATCH] x86/hevc_sao: fix loading of RIP address

2015-02-06 Thread Hendrik Leppkes
On Fri, Feb 6, 2015 at 6:10 PM, Christophe Gisquet wrote: > Hi, > > 2015-02-06 17:54 GMT+01:00 James Almer : >> pb_eo must be handled as a rip relative address for MSVC64, so an >> intermediate register is needed. Should fix link failures. > > Seems ok on principle, passes fate on mingw64. I'm alw

Re: [FFmpeg-devel] [PATCH] x86/hevc_sao: fix loading of RIP address

2015-02-06 Thread Christophe Gisquet
Hi, 2015-02-06 17:54 GMT+01:00 James Almer : > pb_eo must be handled as a rip relative address for MSVC64, so an > intermediate register is needed. Should fix link failures. Seems ok on principle, passes fate on mingw64. I'm always wary of those ABI, so if anyone could verify for msvc64 and unix6

[FFmpeg-devel] [PATCH] x86/hevc_sao: fix loading of RIP address

2015-02-06 Thread James Almer
pb_eo must be handled as a rip relative address for MSVC64, so an intermediate register is needed. Should fix link failures. Suggested by Hendrik Leppkes and Christophe Gisquet. Signed-off-by: James Almer --- libavcodec/x86/hevc_sao.asm | 42 +- 1 file ch