Re: [FFmpeg-devel] [PATCH] x86/dcadec: add ff_lfe_fir1_float_{sse3, avx}

2016-02-22 Thread James Almer
On 2/22/2016 8:14 PM, Christophe Gisquet wrote: > Hi, >> +.inner_loop: > > Given this precludes reusing m5, then I don't have anything more to > comment, and seems ok. Pushed then, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ff

Re: [FFmpeg-devel] [PATCH] x86/dcadec: add ff_lfe_fir1_float_{sse3, avx}

2016-02-22 Thread Christophe Gisquet
Hi, > +.inner_loop: Given this precludes reusing m5, then I don't have anything more to comment, and seems ok. -- Christophe ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] x86/dcadec: add ff_lfe_fir1_float_{sse3, avx}

2016-02-22 Thread James Almer
On 2/22/2016 8:02 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/x86/dcadsp.asm| 79 > > libavcodec/x86/dcadsp_init.c | 9 - > 2 files changed, 87 insertions(+), 1 deletion(-) The FATE suit doesn't cover this function

[FFmpeg-devel] [PATCH] x86/dcadec: add ff_lfe_fir1_float_{sse3, avx}

2016-02-22 Thread James Almer
Signed-off-by: James Almer --- libavcodec/x86/dcadsp.asm| 79 libavcodec/x86/dcadsp_init.c | 9 - 2 files changed, 87 insertions(+), 1 deletion(-) diff --git a/libavcodec/x86/dcadsp.asm b/libavcodec/x86/dcadsp.asm index fb13957..c5bf21a 10064

Re: [FFmpeg-devel] [PATCH] x86/dcadec: add ff_lfe_fir1_float_{sse3, avx}

2016-02-22 Thread James Almer
On 2/22/2016 7:44 PM, Christophe Gisquet wrote: > Hi, > > 2016-02-22 22:43 GMT+01:00 James Almer : >> +.loop: >> +%if cpuflag(avx) >> +cvtdq2ps m4, [lfeq] >> +shufpsm5, m4, m4, q0123 >> +%elif cpuflag(sse2) >> +movu m4, [lfeq] >> +cvtdq2ps m4, m4 >> +pshufdm5, m4

Re: [FFmpeg-devel] [PATCH] x86/dcadec: add ff_lfe_fir1_float_{sse3, avx}

2016-02-22 Thread Christophe Gisquet
Hi, 2016-02-22 22:43 GMT+01:00 James Almer : > +.loop: > +%if cpuflag(avx) > +cvtdq2ps m4, [lfeq] > +shufpsm5, m4, m4, q0123 > +%elif cpuflag(sse2) > +movu m4, [lfeq] > +cvtdq2ps m4, m4 > +pshufdm5, m4, q0123 > +%endif > + > +.inner_loop: > +%if ARCH_X86_64 > +

[FFmpeg-devel] [PATCH] x86/dcadec: add ff_lfe_fir1_float_{sse3, avx}

2016-02-22 Thread James Almer
Signed-off-by: James Almer --- libavcodec/x86/dcadsp.asm| 86 libavcodec/x86/dcadsp_init.c | 9 - 2 files changed, 94 insertions(+), 1 deletion(-) diff --git a/libavcodec/x86/dcadsp.asm b/libavcodec/x86/dcadsp.asm index fb13957..bea834f 10064