On Wed, Dec 17, 2014 at 12:04:37PM +0100, Thomas Volkert wrote:
> From: Thomas Volkert
>
> ---
> Changelog | 1 +
> libavformat/act.c | 2 +-
> libavformat/asfdec.c | 2 +-
> libavformat/avidec.c | 2 +-
> libavformat/dxa.c | 2 +-
> libavformat/mat
On 12/17/2014 10:57 PM, Benoit Fouet wrote:
Hi,
Le 17/12/2014 22:15, Reimar Döffinger a écrit :
On Wed, Dec 17, 2014 at 11:55:17AM +0100, Thomas Volkert wrote:
On 12/16/2014 08:36 AM, Reimar Döffinger wrote:
On Mon, Dec 15, 2014 at 10:24:55AM +, Carl Eugen Hoyos wrote:
codec->samp
Hi,
Le 17/12/2014 22:15, Reimar Döffinger a écrit :
On Wed, Dec 17, 2014 at 11:55:17AM +0100, Thomas Volkert wrote:
On 12/16/2014 08:36 AM, Reimar Döffinger wrote:
On Mon, Dec 15, 2014 at 10:24:55AM +, Carl Eugen Hoyos wrote:
codec->sample_rate = avio_rl32(pb);
codec->bit_ra
On Wed, Dec 17, 2014 at 11:55:17AM +0100, Thomas Volkert wrote:
> On 12/16/2014 08:36 AM, Reimar Döffinger wrote:
> >On Mon, Dec 15, 2014 at 10:24:55AM +, Carl Eugen Hoyos wrote:
> >>> codec->sample_rate = avio_rl32(pb);
> >>> codec->bit_rate= avio_rl32(pb) * 8;
> >>> code
From: Thomas Volkert
---
Changelog | 1 +
libavformat/act.c | 2 +-
libavformat/asfdec.c | 2 +-
libavformat/avidec.c | 2 +-
libavformat/dxa.c | 2 +-
libavformat/matroskadec.c | 2 +-
libavformat/mlvdec.c | 2 +-
libavformat/mov.c |
On 12/16/2014 08:36 AM, Reimar Döffinger wrote:
On Mon, Dec 15, 2014 at 10:24:55AM +, Carl Eugen Hoyos wrote:
codec->sample_rate = avio_rl32(pb);
codec->bit_rate= avio_rl32(pb) * 8;
codec->block_align = avio_rl16(pb);
+if (big_endian) {
+id
Thomas Volkert gmx.net> writes:
> -id = avio_rl16(pb);
> codec->codec_type = AVMEDIA_TYPE_AUDIO;
> -codec->channels= avio_rl16(pb);
> -codec->sample_rate = avio_rl32(pb);
> -codec->bit_rate= avio_rl32(pb) * 8;
> -codec->block_align = avio_rl16(pb)
From: Thomas Volkert
---
Changelog | 1 +
libavformat/act.c | 2 +-
libavformat/asfdec.c | 2 +-
libavformat/avidec.c | 2 +-
libavformat/dxa.c | 2 +-
libavformat/matroskadec.c | 2 +-
libavformat/mlvdec.c | 2 +-
libavformat/mov.c |
Thomas Volkert gmx.net> writes:
> if (size >= 18) { /* We're obviously dealing with WAVEFORMATEX */
> -int cbSize = avio_rl16(pb); /* cbSize */
> +int cbSize = (!big_endian ? avio_rl16(pb) :
> avio_rb16(pb)); /* cbSize */
This change looks useless to me given that you erro
From: Thomas Volkert
---
Changelog | 1 +
libavformat/act.c | 2 +-
libavformat/asfdec.c | 2 +-
libavformat/avidec.c | 2 +-
libavformat/dxa.c | 2 +-
libavformat/matroskadec.c | 2 +-
libavformat/mlvdec.c | 2 +-
libavformat/mov.c |
On Mon, Dec 15, 2014 at 10:24:55AM +, Carl Eugen Hoyos wrote:
> Thomas Volkert gmx.net> writes:
>
> > +#include
>
> This will hopefully be unneeded.
>
> > codec->sample_rate = avio_rl32(pb);
> > codec->bit_rate= avio_rl32(pb) * 8;
> > codec->block_align = avio_rl16(pb
On Mon, 15 Dec 2014 11:10:08 +0100
Thomas Volkert wrote:
> +if (big_endian) {
> +id = ntohs(id);
> +codec->channels= ntohs(codec->channels);
> +codec->sample_rate = ntohl(codec->sample_rate);
> +codec->bit_rate= ntohl(codec->bit_rate / 8
Thomas Volkert gmx.net> writes:
> >>if (size >= 18) { /* We're obviously dealing with WAVEFORMATEX
> >> +if (big_endian)
> >> +avpriv_report_missing_feature(codec,
> >> "WAVEFORMATEX support for RIFX files\n");
> > Is this sufficient, no further error handling needed?
>
> I do n
On 12/15/2014 11:24 AM, Carl Eugen Hoyos wrote:
Thomas Volkert gmx.net> writes:
+#include
This will hopefully be unneeded.
Okay, this will simplify the patch.
if (size >= 18) { /* We're obviously dealing with WAVEFORMATEX */
+if (big_endian)
+avpriv_report_mi
Thomas Volkert gmx.net> writes:
> +#include
This will hopefully be unneeded.
> codec->sample_rate = avio_rl32(pb);
> codec->bit_rate= avio_rl32(pb) * 8;
> codec->block_align = avio_rl16(pb);
> +if (big_endian) {
> +id = ntohs(id);
> +co
This fixes ticket #1978.
From: Thomas Volkert
---
Changelog | 1 +
libavformat/act.c | 2 +-
libavformat/asfdec.c | 2 +-
libavformat/avidec.c | 2 +-
libavformat/dxa.c | 2 +-
libavformat/matroskadec.c | 2 +-
libavformat/mlvdec.c | 2 +-
16 matches
Mail list logo
