Re: [FFmpeg-devel] [PATCH] vp9: don't retain NULL as segmentation_map

> Thanks for this analysis. I've pushed the patch now. > > By the way, afl [1] is really a great tool for finding such problems. > I can only recommend everyone to try it out yourself. Not to push this off-topic but can you let me know how you use afl with ffmpeg - I could never get it to work whe

Re: [FFmpeg-devel] [PATCH] vp9: don't retain NULL as segmentation_map

On 18.06.2015 23:43, Ronald S. Bultje wrote: > OK, looked further, it's actually quite complicated and I don't think > it's easy to do "the correct thing". The reason is that on frame header > error, we don't move the reference frame state forward (that's the code > in vp9_decode_frame right after

Re: [FFmpeg-devel] [PATCH] vp9: don't retain NULL as segmentation_map

Hi Andreas, On Wed, Jun 17, 2015 at 11:56 AM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > Hi Ronald, > > On 17.06.2015 20:26, Ronald S. Bultje wrote: > > On Jun 17, 2015 10:07 AM, "Andreas Cadhalpun" < > > andreas.cadhal...@googlemail.com> wrote: > >> > >> This fixes segmentati

Re: [FFmpeg-devel] [PATCH] vp9: don't retain NULL as segmentation_map

Hi Ronald, On 17.06.2015 20:26, Ronald S. Bultje wrote: > On Jun 17, 2015 10:07 AM, "Andreas Cadhalpun" < > andreas.cadhal...@googlemail.com> wrote: >> >> This fixes segmentation faults, which were introduced in commit >> 4ba8f327. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/vp9.

Re: [FFmpeg-devel] [PATCH] vp9: don't retain NULL as segmentation_map

Hi, On Jun 17, 2015 10:07 AM, "Andreas Cadhalpun" < andreas.cadhal...@googlemail.com> wrote: > > This fixes segmentation faults, which were introduced in commit > 4ba8f327. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/vp9.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

[FFmpeg-devel] [PATCH] vp9: don't retain NULL as segmentation_map

This fixes segmentation faults, which were introduced in commit 4ba8f327. Signed-off-by: Andreas Cadhalpun --- libavcodec/vp9.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 4e2ed53..9d9326c 100644 --- a/libavcodec/vp9.c +++ b/lib