Re: [FFmpeg-devel] [PATCH] vp9: avoid infinite loop with broken files

2015-01-10 Thread Michael Niedermayer
On Sat, Jan 10, 2015 at 01:21:42PM -0500, Ronald S. Bultje wrote: > Hi, > > On Sat, Jan 10, 2015 at 12:15 PM, wm4 wrote: > > > On Sat, 10 Jan 2015 18:03:48 +0100 > > Hendrik Leppkes wrote: > > > > > On Sat, Jan 10, 2015 at 6:00 PM, wm4 wrote: > > > > > > > With a certain fuzzed file, the parse

Re: [FFmpeg-devel] [PATCH] vp9: avoid infinite loop with broken files

2015-01-10 Thread Ronald S. Bultje
Hi, On Sat, Jan 10, 2015 at 12:15 PM, wm4 wrote: > On Sat, 10 Jan 2015 18:03:48 +0100 > Hendrik Leppkes wrote: > > > On Sat, Jan 10, 2015 at 6:00 PM, wm4 wrote: > > > > > With a certain fuzzed file, the parser will always return 0 consumed > > > bytes, which makes calling code call the parser

Re: [FFmpeg-devel] [PATCH] vp9: avoid infinite loop with broken files

2015-01-10 Thread wm4
On Sat, 10 Jan 2015 18:03:48 +0100 Hendrik Leppkes wrote: > On Sat, Jan 10, 2015 at 6:00 PM, wm4 wrote: > > > With a certain fuzzed file, the parser will always return 0 consumed > > bytes, which makes calling code call the parser infinitely. Return the > > full packet size on error instead. (H

Re: [FFmpeg-devel] [PATCH] vp9: avoid infinite loop with broken files

2015-01-10 Thread Hendrik Leppkes
On Sat, Jan 10, 2015 at 6:00 PM, wm4 wrote: > With a certain fuzzed file, the parser will always return 0 consumed > bytes, which makes calling code call the parser infinitely. Return the > full packet size on error instead. (Here it would be nice if parsers > could return errors at all.) > > Add

[FFmpeg-devel] [PATCH] vp9: avoid infinite loop with broken files

2015-01-10 Thread wm4
With a certain fuzzed file, the parser will always return 0 consumed bytes, which makes calling code call the parser infinitely. Return the full packet size on error instead. (Here it would be nice if parsers could return errors at all.) Additionally, _if_ there's some data left, return that too,