Re: [FFmpeg-devel] [PATCH] tx_float_neon: Do not access outside stack.

2022-10-09 Thread Rémi Denis-Courmont
Le sunnuntaina 9. lokakuuta 2022, 19.36.24 EEST Reimar Döffinger a écrit : > > While this fixes the ABI violation, it introduces multiple data > > dependencies on stack pointer due to write-back. > > That is true in principle, this is not done consistently at all. I have not checked the FFmpeg co

Re: [FFmpeg-devel] [PATCH] tx_float_neon: Do not access outside stack.

2022-10-09 Thread Reimar Döffinger
> On 9 Oct 2022, at 16:11, Rémi Denis-Courmont wrote: > > Le sunnuntaina 9. lokakuuta 2022, 16.14.47 EEST Reimar Döffinger a écrit : >> Use load/store instructions that modify sp to save >> registers to stack, like it is done for all other >> functions. >> At least valgrind complains about the

Re: [FFmpeg-devel] [PATCH] tx_float_neon: Do not access outside stack.

2022-10-09 Thread Rémi Denis-Courmont
Le sunnuntaina 9. lokakuuta 2022, 16.14.47 EEST Reimar Döffinger a écrit : > Use load/store instructions that modify sp to save > registers to stack, like it is done for all other > functions. > At least valgrind complains about the current code. > --- > libavutil/aarch64/tx_float_neon.S | 16

[FFmpeg-devel] [PATCH] tx_float_neon: Do not access outside stack.

2022-10-09 Thread Reimar Döffinger
Use load/store instructions that modify sp to save registers to stack, like it is done for all other functions. At least valgrind complains about the current code. --- libavutil/aarch64/tx_float_neon.S | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavutil/a