Re: [FFmpeg-devel] [PATCH] swresample/options: change rematrix_maxval default to 1.0

2015-11-07 Thread wm4
On Sat, 7 Nov 2015 18:33:07 +0100 Michael Niedermayer wrote: > On Fri, Nov 06, 2015 at 01:48:59PM +0100, wm4 wrote: > > On Fri, 6 Nov 2015 12:58:23 +0100 > > Michael Niedermayer wrote: > > > > > On Fri, Nov 06, 2015 at 11:16:49AM +0100, wm4 wrote: > > > > On Fri, 6 Nov 2015 10:54:28 +0100 >

Re: [FFmpeg-devel] [PATCH] swresample/options: change rematrix_maxval default to 1.0

2015-11-07 Thread Michael Niedermayer
On Fri, Nov 06, 2015 at 01:48:59PM +0100, wm4 wrote: > On Fri, 6 Nov 2015 12:58:23 +0100 > Michael Niedermayer wrote: > > > On Fri, Nov 06, 2015 at 11:16:49AM +0100, wm4 wrote: > > > On Fri, 6 Nov 2015 10:54:28 +0100 > > > Michael Niedermayer wrote: > > > > > > > On Fri, Nov 06, 2015 at 08:52

Re: [FFmpeg-devel] [PATCH] swresample/options: change rematrix_maxval default to 1.0

2015-11-07 Thread Ganesh Ajjanagadde
On Fri, Nov 6, 2015 at 2:52 AM, Nicolas George wrote: > Le sextidi 16 brumaire, an CCXXIV, Michael Niedermayer a écrit : >> iam with whatever default people prefer > > IIRC, the current default yields different results when rematrixing from > float to float and then converting from float to int th

Re: [FFmpeg-devel] [PATCH] swresample/options: change rematrix_maxval default to 1.0

2015-11-06 Thread wm4
On Fri, 6 Nov 2015 12:58:23 +0100 Michael Niedermayer wrote: > On Fri, Nov 06, 2015 at 11:16:49AM +0100, wm4 wrote: > > On Fri, 6 Nov 2015 10:54:28 +0100 > > Michael Niedermayer wrote: > > > > > On Fri, Nov 06, 2015 at 08:52:32AM +0100, Nicolas George wrote: > > > > Le sextidi 16 brumaire,

Re: [FFmpeg-devel] [PATCH] swresample/options: change rematrix_maxval default to 1.0

2015-11-06 Thread Michael Niedermayer
On Fri, Nov 06, 2015 at 11:16:49AM +0100, wm4 wrote: > On Fri, 6 Nov 2015 10:54:28 +0100 > Michael Niedermayer wrote: > > > On Fri, Nov 06, 2015 at 08:52:32AM +0100, Nicolas George wrote: > > > Le sextidi 16 brumaire, an CCXXIV, Michael Niedermayer a écrit : > > > > iam with whatever default pe

Re: [FFmpeg-devel] [PATCH] swresample/options: change rematrix_maxval default to 1.0

2015-11-06 Thread wm4
On Fri, 6 Nov 2015 10:54:28 +0100 Michael Niedermayer wrote: > On Fri, Nov 06, 2015 at 08:52:32AM +0100, Nicolas George wrote: > > Le sextidi 16 brumaire, an CCXXIV, Michael Niedermayer a écrit : > > > iam with whatever default people prefer > > > > IIRC, the current default yields different

Re: [FFmpeg-devel] [PATCH] swresample/options: change rematrix_maxval default to 1.0

2015-11-06 Thread Michael Niedermayer
On Fri, Nov 06, 2015 at 08:52:32AM +0100, Nicolas George wrote: > Le sextidi 16 brumaire, an CCXXIV, Michael Niedermayer a écrit : > > iam with whatever default people prefer > > IIRC, the current default yields different results when rematrixing from > float to float and then converting from floa

Re: [FFmpeg-devel] [PATCH] swresample/options: change rematrix_maxval default to 1.0

2015-11-05 Thread Nicolas George
Le sextidi 16 brumaire, an CCXXIV, Michael Niedermayer a écrit : > iam with whatever default people prefer IIRC, the current default yields different results when rematrixing from float to float and then converting from float to int than when doing both in a single step. I beliee this is not good.

Re: [FFmpeg-devel] [PATCH] swresample/options: change rematrix_maxval default to 1.0

2015-11-05 Thread Ganesh Ajjanagadde
On Thu, Nov 5, 2015 at 9:14 PM, Michael Niedermayer wrote: > On Wed, Nov 04, 2015 at 10:40:45PM -0500, Ganesh Ajjanagadde wrote: >> This changes the default to not clip, and thus matches libavresample as >> well. >> >> Documentation has been accordingly updated (with some typo fixes). >> >> API us

Re: [FFmpeg-devel] [PATCH] swresample/options: change rematrix_maxval default to 1.0

2015-11-05 Thread Michael Niedermayer
On Wed, Nov 04, 2015 at 10:40:45PM -0500, Ganesh Ajjanagadde wrote: > This changes the default to not clip, and thus matches libavresample as > well. > > Documentation has been accordingly updated (with some typo fixes). > > API users have complained about this, see e.g > https://github.com/mpv-p

[FFmpeg-devel] [PATCH] swresample/options: change rematrix_maxval default to 1.0

2015-11-04 Thread Ganesh Ajjanagadde
This changes the default to not clip, and thus matches libavresample as well. Documentation has been accordingly updated (with some typo fixes). API users have complained about this, see e.g https://github.com/mpv-player/mpv/commit/bf69edb1c2bac2ac11343d8e086f0540a0e4b5df. Signed-off-by: Ganesh