Re: [FFmpeg-devel] [PATCH] sbr_qmf_analysis: sanitize input for 32-bit imdct

2015-12-10 Thread Andreas Cadhalpun
On 02.12.2015 20:58, Andreas Cadhalpun wrote: > On 19.11.2015 01:02, Andreas Cadhalpun wrote: >> If the input contains too many too large values, the imdct can overflow. >> Even if it didn't, the output would be larger than the valid range of 29 >> bits. >> >> Note that this is a very delicate limi

Re: [FFmpeg-devel] [PATCH] sbr_qmf_analysis: sanitize input for 32-bit imdct

2015-12-02 Thread Andreas Cadhalpun
On 19.11.2015 01:02, Andreas Cadhalpun wrote: > If the input contains too many too large values, the imdct can overflow. > Even if it didn't, the output would be larger than the valid range of 29 > bits. > > Note that this is a very delicate limit: Allowing values up to 1<<25 > does not prevent in

[FFmpeg-devel] [PATCH] sbr_qmf_analysis: sanitize input for 32-bit imdct

2015-11-18 Thread Andreas Cadhalpun
If the input contains too many too large values, the imdct can overflow. Even if it didn't, the output would be larger than the valid range of 29 bits. Note that this is a very delicate limit: Allowing values up to 1<<25 does not prevent input larger than 1<<29 from arriving at sbr_sum_square, whi