Re: [FFmpeg-devel] [PATCH] read reel_name metadata from tmcd atom

2014-08-06 Thread Mark Reid
opps sorry, yes I saw patch the patch comments :) I'll work on another patch with those things fixed! On Wed, Aug 6, 2014 at 3:48 PM, Michael Niedermayer wrote: > On Wed, Aug 06, 2014 at 03:29:04PM -0700, Mark Reid wrote: > > Thanks for the quick feed back! I attached a small sample file, the m

Re: [FFmpeg-devel] [PATCH] read reel_name metadata from tmcd atom

2014-08-06 Thread Michael Niedermayer
On Wed, Aug 06, 2014 at 03:29:04PM -0700, Mark Reid wrote: > Thanks for the quick feed back! I attached a small sample file, the media > was generated with Davinci Resolve. thanks did you see the patch comments below ? you didnt reply to them so i had the feeling you missed them, just want to mak

Re: [FFmpeg-devel] [PATCH] read reel_name metadata from tmcd atom

2014-08-06 Thread Mark Reid
Thanks for the quick feed back! I attached a small sample file, the media was generated with Davinci Resolve. On Wed, Aug 6, 2014 at 3:00 PM, Michael Niedermayer wrote: > On Wed, Aug 06, 2014 at 01:25:08PM -0700, Mark Reid wrote: > > --- > > libavformat/mov.c | 20 > > 1 f

Re: [FFmpeg-devel] [PATCH] read reel_name metadata from tmcd atom

2014-08-06 Thread Michael Niedermayer
On Wed, Aug 06, 2014 at 01:25:08PM -0700, Mark Reid wrote: > --- > libavformat/mov.c | 20 > 1 file changed, 20 insertions(+) do you have a sample / testcase that you can share ? > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index ab85918..fb8d1fe 100644 > --- a

[FFmpeg-devel] [PATCH] read reel_name metadata from tmcd atom

2014-08-06 Thread Mark Reid
--- libavformat/mov.c | 20 1 file changed, 20 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index ab85918..fb8d1fe 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -1529,6 +1529,26 @@ static int mov_parse_stsd_data(MOVContext *c, AVIOContext *pb,

[FFmpeg-devel] [PATCH] read reel_name metadata from tmcd atom

2014-08-06 Thread Mark Reid
Hi, This patch reads reel_name stored in the a tmcd atom in a quicktime mov files as documented here: https://developer.apple.com/library/mac/documentation/quicktime/qtff/QTFFChap3/qtff3.html/apple_ref/doc/uid/TP4939-CH205-57409#//apple_ref/doc/uid/TP4939-CH205-69831 Its called ???Source