Re: [FFmpeg-devel] [PATCH] psy_snr:Psychoacoustic SNR for audio files

2014-10-31 Thread Claudio Freire
I notice you have tons of c++-isms you should check: On Thu, Oct 30, 2014 at 3:03 PM, Senjuti Kundu wrote: > +int i = 0; > +float* maskingfunc = malloc(tempsize*sizeof(float)); > +maskingfunc[tempsize/2] = exp(-db_attenuation*log(10)); Split declaration and initialization, as explain

Re: [FFmpeg-devel] [PATCH] psy_snr:Psychoacoustic SNR for audio files

2014-10-31 Thread Michael Niedermayer
On Thu, Oct 30, 2014 at 11:33:51PM +0530, Senjuti Kundu wrote: > Implemented an SNR for audio files which takes into a account the > psychoacoustic masking. This results in an SNR which is closer to how humans > percieve sound, compared to tiny_psnr which directly compares audio signals > > Sign

Re: [FFmpeg-devel] [PATCH] psy_snr:Psychoacoustic SNR for audio files

2014-10-30 Thread Michael Niedermayer
On Thu, Oct 30, 2014 at 11:33:51PM +0530, Senjuti Kundu wrote: > Implemented an SNR for audio files which takes into a account the > psychoacoustic masking. This results in an SNR which is closer to how humans > percieve sound, compared to tiny_psnr which directly compares audio signals > > Sign

[FFmpeg-devel] [PATCH] psy_snr:Psychoacoustic SNR for audio files

2014-10-30 Thread Senjuti Kundu
Implemented an SNR for audio files which takes into a account the psychoacoustic masking. This results in an SNR which is closer to how humans percieve sound, compared to tiny_psnr which directly compares audio signals Signed-off-by: Senjuti Kundu --- tests/psy_snr.c | 421