Re: [FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-03 Thread Michael Niedermayer
On Wed, Dec 03, 2014 at 09:47:45AM +0100, Benoit Fouet wrote: > Hi, > > - Mail original - > > Hi, > > > > 2014-12-02 14:31 GMT+01:00 Benoit Fouet : > > > Fixes ticket #4148 > > > > Please try that one instead. > > > > Works fine, thanks. > Please fix commit message: s/onlu/only fixed

Re: [FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-03 Thread Benoit Fouet
Hi, - Mail original - > Hi, > > 2014-12-02 14:31 GMT+01:00 Benoit Fouet : > > Fixes ticket #4148 > > Please try that one instead. > Works fine, thanks. Please fix commit message: s/onlu/only > As all your changes have been reverted, I've put myself as the only > author. I've left your

Re: [FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-02 Thread Christophe Gisquet
Hi, 2014-12-02 14:31 GMT+01:00 Benoit Fouet : > Fixes ticket #4148 Please try that one instead. As all your changes have been reverted, I've put myself as the only author. I've left your "signed-off-by", but I'm not sure of its purpose now. Christophe From 76ddca41e1f4ab4df348b64ddbf63c58153c8c

[FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-02 Thread Benoit Fouet
Fixes ticket #4148 Signed-off-by: Christophe Gisquet Signed-off-by: Benoit Fouet --- Add TODO Update function prototype documentation Mention ticket 4148 --- libavcodec/pngdsp.h | 2 ++ libavcodec/x86/pngdsp.asm | 7 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/li

Re: [FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-02 Thread Benoit Fouet
Hi, - Mail original - > Benoit Fouet free.fr> writes: > > [...] > > Please mention ticket #4148 (if it is related). > It is, just forgot about it. Also, I should be changing the libavcodec/pngdsp.h to no more mention the alignment constraints (or at least document that, for now, unal

Re: [FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-02 Thread Benoit Fouet
Hi, - Mail original - > Hi, > > 2014-12-02 13:51 GMT+01:00 Benoit Fouet : > > Signed-off-by: Christophe Gisquet > > Signed-off-by: Benoit Fouet > > While I suggested that the change be written like this, I didn't > think > long about that specific code, and overall, I really don't thin

Re: [FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-02 Thread Christophe Gisquet
Hi, 2014-12-02 13:51 GMT+01:00 Benoit Fouet : > Signed-off-by: Christophe Gisquet > Signed-off-by: Benoit Fouet While I suggested that the change be written like this, I didn't think long about that specific code, and overall, I really don't think this change is what should be applied. Though y

Re: [FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-02 Thread Carl Eugen Hoyos
Benoit Fouet free.fr> writes: [...] Please mention ticket #4148 (if it is related). Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-02 Thread Benoit Fouet
Signed-off-by: Christophe Gisquet Signed-off-by: Benoit Fouet --- libavcodec/x86/pngdsp.asm | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/x86/pngdsp.asm b/libavcodec/x86/pngdsp.asm index 8e23ccf..76b93a9 100644 --- a/libavcodec/x86/pngdsp.asm +++ b/libavcode