Re: [FFmpeg-devel] [PATCH] parser: error out if the codec doesn't match

On 05.01.2016 21:40, Michael Niedermayer wrote: > On Tue, Jan 05, 2016 at 12:48:10PM +0100, Andreas Cadhalpun wrote: >> parser.c |7 +++ >> 1 file changed, 7 insertions(+) >> 1a29aebd63e39c82039cddb1239de415b1da43df >> 0001-parser-add-av_assert1-to-make-sure-the-codec-matches.patch >> Fr

Re: [FFmpeg-devel] [PATCH] parser: error out if the codec doesn't match

On Tue, Jan 05, 2016 at 12:48:10PM +0100, Andreas Cadhalpun wrote: > On 05.01.2016 12:18, Michael Niedermayer wrote: > > On Tue, Jan 05, 2016 at 12:02:29PM +0100, Andreas Cadhalpun wrote: > >> That wouldn't work, as the codec id wasn't changed in force_codec_ids, > >> but in the API using program.

Re: [FFmpeg-devel] [PATCH] parser: error out if the codec doesn't match

On 05.01.2016 12:18, Michael Niedermayer wrote: > On Tue, Jan 05, 2016 at 12:02:29PM +0100, Andreas Cadhalpun wrote: >> That wouldn't work, as the codec id wasn't changed in force_codec_ids, >> but in the API using program. >> To reiterate, the problematic steps were: >> * call avformat_find_strea

Re: [FFmpeg-devel] [PATCH] parser: error out if the codec doesn't match

On Tue, Jan 05, 2016 at 12:02:29PM +0100, Andreas Cadhalpun wrote: > On 05.01.2016 11:46, Michael Niedermayer wrote: > > On Tue, Jan 05, 2016 at 12:44:40AM +0100, Andreas Cadhalpun wrote: > >> Otherwise this can have some surprising effects (crashes), so let's > >> better not allow it. > >> > >> Si

Re: [FFmpeg-devel] [PATCH] parser: error out if the codec doesn't match

On 05.01.2016 11:46, Michael Niedermayer wrote: > On Tue, Jan 05, 2016 at 12:44:40AM +0100, Andreas Cadhalpun wrote: >> Otherwise this can have some surprising effects (crashes), so let's >> better not allow it. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/parser.c | 11 +++

Re: [FFmpeg-devel] [PATCH] parser: error out if the codec doesn't match

On Tue, Jan 5, 2016 at 11:46 AM, Michael Niedermayer wrote: > On Tue, Jan 05, 2016 at 12:44:40AM +0100, Andreas Cadhalpun wrote: >> Otherwise this can have some surprising effects (crashes), so let's >> better not allow it. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/parser.c | 1

Re: [FFmpeg-devel] [PATCH] parser: error out if the codec doesn't match

On Tue, Jan 05, 2016 at 12:44:40AM +0100, Andreas Cadhalpun wrote: > Otherwise this can have some surprising effects (crashes), so let's > better not allow it. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/parser.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/

Re: [FFmpeg-devel] [PATCH] parser: error out if the codec doesn't match

On Mon, Jan 4, 2016 at 4:05 PM, Andreas Cadhalpun wrote: > On 05.01.2016 00:51, Ganesh Ajjanagadde wrote: >> On Mon, Jan 4, 2016 at 3:44 PM, Andreas Cadhalpun >> wrote: >>> Otherwise this can have some surprising effects (crashes), so let's >>> better not allow it. >>> >>> Signed-off-by: Andreas

Re: [FFmpeg-devel] [PATCH] parser: error out if the codec doesn't match

On 05.01.2016 00:51, Ganesh Ajjanagadde wrote: > On Mon, Jan 4, 2016 at 3:44 PM, Andreas Cadhalpun > wrote: >> Otherwise this can have some surprising effects (crashes), so let's >> better not allow it. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/parser.c | 11 +++ >> 1 f

Re: [FFmpeg-devel] [PATCH] parser: error out if the codec doesn't match

On Mon, Jan 4, 2016 at 3:44 PM, Andreas Cadhalpun wrote: > Otherwise this can have some surprising effects (crashes), so let's > better not allow it. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/parser.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/libavcodec/

[FFmpeg-devel] [PATCH] parser: error out if the codec doesn't match

Otherwise this can have some surprising effects (crashes), so let's better not allow it. Signed-off-by: Andreas Cadhalpun --- libavcodec/parser.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavcodec/parser.c b/libavcodec/parser.c index 2809158..1f38edb 100644 --- a/libavco