Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

On 11.12.2016 21:45, Andreas Cadhalpun wrote: > On 11.12.2016 21:03, Hendrik Leppkes wrote: >> On Sun, Dec 11, 2016 at 7:48 PM, Andreas Cadhalpun >> wrote: >>> On 11.12.2016 10:04, Hendrik Leppkes wrote: I still see the problem that this option code does not know which pix_fmt the number

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

On 11.12.2016 21:03, Hendrik Leppkes wrote: > On Sun, Dec 11, 2016 at 7:48 PM, Andreas Cadhalpun > wrote: >> On 11.12.2016 10:04, Hendrik Leppkes wrote: >>> I still see the problem that this option code does not know which >>> pix_fmt the numbers relate to and as such would keep the old limit in >

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

On Sun, Dec 11, 2016 at 7:48 PM, Andreas Cadhalpun wrote: > On 11.12.2016 10:04, Hendrik Leppkes wrote: >> On Sat, Dec 10, 2016 at 6:53 PM, Andreas Cadhalpun >> wrote: >>> On 10.12.2016 18:40, Hendrik Leppkes wrote: and just adds extra burden when these limits are changed/improved (say

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

On 11.12.2016 10:04, Hendrik Leppkes wrote: > On Sat, Dec 10, 2016 at 6:53 PM, Andreas Cadhalpun > wrote: >> On 10.12.2016 18:40, Hendrik Leppkes wrote: >>> and just adds extra burden when these limits are >>> changed/improved (say by making them pixfmt aware as discussed in >>> another thread, wh

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

On Sat, Dec 10, 2016 at 6:53 PM, Andreas Cadhalpun wrote: > On 10.12.2016 18:40, Hendrik Leppkes wrote: >> On Sat, Dec 10, 2016 at 6:20 PM, Andreas Cadhalpun >> wrote: >>> On 10.12.2016 17:29, Hendrik Leppkes wrote: On Sat, Dec 10, 2016 at 4:55 PM, Andreas Cadhalpun wrote: > If tha

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

On 10.12.2016 18:40, Hendrik Leppkes wrote: > On Sat, Dec 10, 2016 at 6:20 PM, Andreas Cadhalpun > wrote: >> On 10.12.2016 17:29, Hendrik Leppkes wrote: >>> On Sat, Dec 10, 2016 at 4:55 PM, Andreas Cadhalpun >>> wrote: If that is done, the hard limit in av_image_check_size should check for >

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

On Sat, Dec 10, 2016 at 6:20 PM, Andreas Cadhalpun wrote: > On 10.12.2016 17:29, Hendrik Leppkes wrote: >> On Sat, Dec 10, 2016 at 4:55 PM, Andreas Cadhalpun >> wrote: >>> If that is done, the hard limit in av_image_check_size should check for >>> the maximum allowed value of any pixel format. >>

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

On 10.12.2016 17:29, Hendrik Leppkes wrote: > On Sat, Dec 10, 2016 at 4:55 PM, Andreas Cadhalpun > wrote: >> If that is done, the hard limit in av_image_check_size should check for >> the maximum allowed value of any pixel format. >> But a check here is needed to make sure that width * height does

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

On Sat, Dec 10, 2016 at 4:55 PM, Andreas Cadhalpun wrote: > On 10.12.2016 16:26, wm4 wrote: >> On Sat, 10 Dec 2016 16:11:15 +0100 >> Andreas Cadhalpun wrote: >> >>> Signed-off-by: Andreas Cadhalpun >>> --- >>> libavutil/opt.c | 10 +- >>> 1 file changed, 9 insertions(+), 1 deletion(-) >

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-10 16:55 GMT+01:00 Andreas Cadhalpun : > On 10.12.2016 16:19, Carl Eugen Hoyos wrote: >> 2016-12-10 16:11 GMT+01:00 Andreas Cadhalpun >> : >>> Signed-off-by: Andreas Cadhalpun >>> --- >>> libavutil/opt.c | 10 +- >>> 1 file changed, 9 insertions(+), 1 deletion(-) >>> >>> diff --g

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-10 16:54 GMT+01:00 Hendrik Leppkes : > Allocations would need to be checked anyway with or without this check Do you think this is related? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmp

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

On 10.12.2016 16:26, wm4 wrote: > On Sat, 10 Dec 2016 16:11:15 +0100 > Andreas Cadhalpun wrote: > >> Signed-off-by: Andreas Cadhalpun >> --- >> libavutil/opt.c | 10 +- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/libavutil/opt.c b/libavutil/opt.c >> index f855cc

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

On 10.12.2016 16:19, Carl Eugen Hoyos wrote: > 2016-12-10 16:11 GMT+01:00 Andreas Cadhalpun > : >> Signed-off-by: Andreas Cadhalpun >> --- >> libavutil/opt.c | 10 +- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/libavutil/opt.c b/libavutil/opt.c >> index f855ccb..

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

On Sat, Dec 10, 2016 at 4:26 PM, wm4 wrote: > On Sat, 10 Dec 2016 16:11:15 +0100 > Andreas Cadhalpun wrote: > >> Signed-off-by: Andreas Cadhalpun >> --- >> libavutil/opt.c | 10 +- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/libavutil/opt.c b/libavutil/opt.c >>

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-10 16:11 GMT+01:00 Andreas Cadhalpun : > Signed-off-by: Andreas Cadhalpun > --- > libavutil/opt.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/libavutil/opt.c b/libavutil/opt.c > index f855ccb..f713d3f 100644 > --- a/libavutil/opt.c > +++ b/libavutil/

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

On Sat, 10 Dec 2016 16:11:15 +0100 Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavutil/opt.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/libavutil/opt.c b/libavutil/opt.c > index f855ccb..f713d3f 100644 > --- a/libavutil/opt.c >

[FFmpeg-devel] [PATCH] opt: check image size when setting it

Signed-off-by: Andreas Cadhalpun --- libavutil/opt.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index f855ccb..f713d3f 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -32,6 +32,7 @@ #include "common.h" #include "dict.h"