Re: [FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v5']

2017-03-03 Thread Michael Niedermayer
On Fri, Mar 03, 2017 at 03:17:37PM +0900, Takayuki 'January June' Suwa wrote: > From: Takayuki 'January June' Suwa > > This adds "-profile[:v] profile_name"-style option. > --- > libavcodec/omx.c | 18 ++ > 1 file changed, 18 insertions(+) applied thx [...] -- Michael Gnu

[FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v5']

2017-03-02 Thread Takayuki 'January June' Suwa
From: Takayuki 'January June' Suwa This adds "-profile[:v] profile_name"-style option. --- libavcodec/omx.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavcodec/omx.c b/libavcodec/omx.c index 16df50e..19b4f33 100644 --- a/libavcodec/omx.c +++ b/libavcodec/omx.c @@ -

Re: [FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v5]

2017-03-02 Thread Michael Niedermayer
On Wed, Mar 01, 2017 at 05:42:29AM +0900, Takayuki 'January June' Suwa wrote: > From: Takayuki 'January June' Suwa > > This adds "-profile[:v] profile_name"-style option. > --- > libavcodec/omx.c | 33 + > 1 file changed, 33 insertions(+) > > diff --git a/libavco

[FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v5]

2017-03-01 Thread Takayuki 'January June' Suwa
From: Takayuki 'January June' Suwa This adds "-profile[:v] profile_name"-style option. --- libavcodec/omx.c | 33 + 1 file changed, 33 insertions(+) diff --git a/libavcodec/omx.c b/libavcodec/omx.c index 16df50e..c0d64e2 100644 --- a/libavcodec/omx.c +++ b/libavc

Re: [FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v4]

2017-02-23 Thread Mark Thompson
On 11/02/17 22:56, Takayuki 'January June' Suwa wrote: > From: Takayuki 'January June' Suwa > > This adds "-profile[:v] profile_name"-style option. > --- > libavcodec/omx.c | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git a/libavcodec/omx.c b/libavcodec/om

[FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v4]

2017-02-12 Thread Takayuki 'January June' Suwa
From: Takayuki 'January June' Suwa This adds "-profile[:v] profile_name"-style option. --- libavcodec/omx.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/libavcodec/omx.c b/libavcodec/omx.c index 16df50e..cfe2613 100644 --- a/libavcodec/omx.c +++ b/libavcod

Re: [FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v3]

2017-02-09 Thread Mark Thompson
On 09/02/17 20:54, Mark Thompson wrote: > On 08/02/17 19:21, Takayuki 'January June' Suwa wrote: >> From: Takayuki 'January June' Suwa >> >> This adds "-profile[:v] profile_name"-style option IOW. >> >> Now default/unknown profile means FF_PROFILE_H264_HIGH strictly, for both >> better coding sty

Re: [FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v3]

2017-02-09 Thread Mark Thompson
On 08/02/17 19:21, Takayuki 'January June' Suwa wrote: > From: Takayuki 'January June' Suwa > > This adds "-profile[:v] profile_name"-style option IOW. > > Now default/unknown profile means FF_PROFILE_H264_HIGH strictly, for both > better coding style and preserving the original behavior. > ---

[FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v3]

2017-02-09 Thread Takayuki 'January June' Suwa
From: Takayuki 'January June' Suwa This adds "-profile[:v] profile_name"-style option IOW. Now default/unknown profile means FF_PROFILE_H264_HIGH strictly, for both better coding style and preserving the original behavior. --- libavcodec/omx.c | 20 1 file changed, 20 inse

Re: [FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v2']

2017-02-08 Thread Moritz Barsnick
On Wed, Feb 08, 2017 at 11:12:12 +0100, Moritz Barsnick wrote: > Your switch/case no longer has a default. Is that intended? (Code > linters will complain.) AFAICT, avctx->profile will be unset if an > unknown s->profile is given. Is that okay? (It might be - I'm just > wondering. I *do* understand

Re: [FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v2']

2017-02-08 Thread Moritz Barsnick
On Tue, Feb 07, 2017 at 19:05:55 +0900, Takayuki 'January June' Suwa wrote: > +switch (s->profile) { > +case FF_PROFILE_H264_BASELINE: > +avctx->profile = s->profile; > +avc.eProfile = OMX_VIDEO_AVCProfileBaseline; > +break; > +case FF_PRO

[FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v2']

2017-02-07 Thread Takayuki 'January June' Suwa
From: Takayuki 'January June' Suwa This adds "-profile[:v] profile_name"-style option IOW. Thanks for reviewing my poor ugly patch, Mark... and I get back to an original purpose - forcing OMX to use baseline profile. (eg. RasPiCam-to-Ustream webcasting w/o additional xcoding) --- libavcodec/o

Re: [FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v2]

2017-02-06 Thread Michael Niedermayer
On Tue, Feb 07, 2017 at 06:28:11AM +0900, Takayuki 'January June' Suwa wrote: > This adds "-profile[:v] profile_name"-style option IOW. > > Thanks for reviewing my poor ugly patch, Mark... and I get back to > an original purpose - forcing OMX to use baseline profile. > (eg. RasPiCam-to-Ustream we

[FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v2]

2017-02-06 Thread Takayuki 'January June' Suwa
This adds "-profile[:v] profile_name"-style option IOW. Thanks for reviewing my poor ugly patch, Mark... and I get back to an original purpose - forcing OMX to use baseline profile. (eg. RasPiCam-to-Ustream webcasting w/o additional xcoding) --- libavcodec/omx.c | 19 +++ 1 fi

Re: [FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile

2017-02-05 Thread Mark Thompson
On 04/02/17 20:26, Takayuki 'January June' Suwa wrote: > This adds "-profile[:v] profile_name"-style option IOW. > "constrained," "baseline," "main" and "high" will work well on Raspbian > Jessie / RasPi3B. > The others aren't checked due to unsupported. The idea of this patch looks sensible to m

[FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile

2017-02-05 Thread Takayuki 'January June' Suwa
This adds "-profile[:v] profile_name"-style option IOW. "constrained," "baseline," "main" and "high" will work well on Raspbian Jessie / RasPi3B. The others aren't checked due to unsupported. --- libavcodec/omx.c | 91 1 file changed, 9