Re: [FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v2']

2017-02-08 Thread Moritz Barsnick
On Wed, Feb 08, 2017 at 11:12:12 +0100, Moritz Barsnick wrote: > Your switch/case no longer has a default. Is that intended? (Code > linters will complain.) AFAICT, avctx->profile will be unset if an > unknown s->profile is given. Is that okay? (It might be - I'm just > wondering. I *do* understand

Re: [FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v2']

2017-02-08 Thread Moritz Barsnick
On Tue, Feb 07, 2017 at 19:05:55 +0900, Takayuki 'January June' Suwa wrote: > +switch (s->profile) { > +case FF_PROFILE_H264_BASELINE: > +avctx->profile = s->profile; > +avc.eProfile = OMX_VIDEO_AVCProfileBaseline; > +break; > +case FF_PRO

[FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v2']

2017-02-07 Thread Takayuki 'January June' Suwa
From: Takayuki 'January June' Suwa This adds "-profile[:v] profile_name"-style option IOW. Thanks for reviewing my poor ugly patch, Mark... and I get back to an original purpose - forcing OMX to use baseline profile. (eg. RasPiCam-to-Ustream webcasting w/o additional xcoding) --- libavcodec/o

Re: [FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v2]

2017-02-06 Thread Michael Niedermayer
On Tue, Feb 07, 2017 at 06:28:11AM +0900, Takayuki 'January June' Suwa wrote: > This adds "-profile[:v] profile_name"-style option IOW. > > Thanks for reviewing my poor ugly patch, Mark... and I get back to > an original purpose - forcing OMX to use baseline profile. > (eg. RasPiCam-to-Ustream we

[FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v2]

2017-02-06 Thread Takayuki 'January June' Suwa
This adds "-profile[:v] profile_name"-style option IOW. Thanks for reviewing my poor ugly patch, Mark... and I get back to an original purpose - forcing OMX to use baseline profile. (eg. RasPiCam-to-Ustream webcasting w/o additional xcoding) --- libavcodec/omx.c | 19 +++ 1 fi