On 02.01.2016 02:11, Michael Niedermayer wrote:
> On Wed, Dec 30, 2015 at 01:00:43AM +0100, Andreas Cadhalpun wrote:
>> From 4380123388f38eb9bbd11db34b0ac82a9ec18d5a Mon Sep 17 00:00:00 2001
>> From: Andreas Cadhalpun
>> Date: Tue, 29 Dec 2015 18:32:01 +0100
>> Subject: [PATCH] oggparsedaala: reje
On Wed, Dec 30, 2015 at 01:00:43AM +0100, Andreas Cadhalpun wrote:
> On 29.12.2015 22:27, Rostislav Pehlivanov wrote:
> > oggparsetheora has the same bit of code to read the gpshift, so it would
> > probably be a good idea to add it to this patch as well.
>
> No, oggparsetheora only reads 5 bits f
On Tue, Dec 29, 2015 at 4:14 PM, Andreas Cadhalpun
wrote:
> On 30.12.2015 01:04, Ganesh Ajjanagadde wrote:
>> On Tue, Dec 29, 2015 at 4:00 PM, Andreas Cadhalpun
>> wrote:
>>> On 29.12.2015 22:27, Rostislav Pehlivanov wrote:
oggparsetheora has the same bit of code to read the gpshift, so it w
On 30.12.2015 01:04, Ganesh Ajjanagadde wrote:
> On Tue, Dec 29, 2015 at 4:00 PM, Andreas Cadhalpun
> wrote:
>> On 29.12.2015 22:27, Rostislav Pehlivanov wrote:
>>> oggparsetheora has the same bit of code to read the gpshift, so it would
>>> probably be a good idea to add it to this patch as well.
On Tue, Dec 29, 2015 at 4:00 PM, Andreas Cadhalpun
wrote:
> On 29.12.2015 22:27, Rostislav Pehlivanov wrote:
>> oggparsetheora has the same bit of code to read the gpshift, so it would
>> probably be a good idea to add it to this patch as well.
>
> No, oggparsetheora only reads 5 bits for gpshift.
On 29.12.2015 22:27, Rostislav Pehlivanov wrote:
> oggparsetheora has the same bit of code to read the gpshift, so it would
> probably be a good idea to add it to this patch as well.
No, oggparsetheora only reads 5 bits for gpshift.
The only thing from this patch that also applies there is the (th
On Tue, Dec 29, 2015 at 6:55 PM, Andreas Cadhalpun
wrote:
> Also use uint32_t for the shift calculation, as 1 << 31 is undefined
> for int32_t.
>
> This fixes ubsan runtime error: shift exponent is too large for
> 32-bit type 'int'
>
> Signed-off-by: Andreas Cadhalpun
> ---
> libavformat/oggpars
oggparsetheora has the same bit of code to read the gpshift, so it would
probably be a good idea to add it to this patch as well.
On 29 December 2015 at 17:55, Andreas Cadhalpun <
andreas.cadhal...@googlemail.com> wrote:
> Also use uint32_t for the shift calculation, as 1 << 31 is undefined
> for
Also use uint32_t for the shift calculation, as 1 << 31 is undefined
for int32_t.
This fixes ubsan runtime error: shift exponent is too large for
32-bit type 'int'
Signed-off-by: Andreas Cadhalpun
---
libavformat/oggparsedaala.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff
