Re: [FFmpeg-devel] [PATCH] nvenc: FIX wrong forced keyframe behavior

2017-02-12 Thread Miroslav Slugeň
Dne 12.2.2017 v 21:01 Timo Rothenpieler napsal(a): On 2/12/2017 8:56 PM, Miroslav Slugeň wrote: 2. We should change it in libx264 and libx265 Changing it in nvenc now would be kind of an API break, as the behaviour might change without someone expecting it. _

Re: [FFmpeg-devel] [PATCH] nvenc: FIX wrong forced keyframe behavior

2017-02-12 Thread Timo Rothenpieler
On 2/12/2017 8:56 PM, Miroslav Slugeň wrote: >>> 2. We should change it in libx264 and libx265 >> Changing it in nvenc now would be kind of an API break, as the behaviour >> might change without someone expecting it. >> ___ >> ffmpeg-devel mailing list >>

Re: [FFmpeg-devel] [PATCH] nvenc: FIX wrong forced keyframe behavior

2017-02-12 Thread Miroslav Slugeň
Dne 12.2.2017 v 20:52 Timo Rothenpieler napsal(a): On 2/12/2017 8:43 PM, Miroslav Slugeň wrote: Dne 12.2.2017 v 20:29 Timo Rothenpieler napsal(a): The current behavior is intended like it is. On the default of -1, it does not care about I/IDR frame requests, in mode 0 it will generate intra fra

Re: [FFmpeg-devel] [PATCH] nvenc: FIX wrong forced keyframe behavior

2017-02-12 Thread Timo Rothenpieler
On 2/12/2017 8:43 PM, Miroslav Slugeň wrote: > Dne 12.2.2017 v 20:29 Timo Rothenpieler napsal(a): >> The current behavior is intended like it is. >> On the default of -1, it does not care about I/IDR frame requests, in >> mode 0 it will generate intra frames, and in mode 1 it will generate >> full

Re: [FFmpeg-devel] [PATCH] nvenc: FIX wrong forced keyframe behavior

2017-02-12 Thread Miroslav Slugeň
Dne 12.2.2017 v 20:29 Timo Rothenpieler napsal(a): The current behavior is intended like it is. On the default of -1, it does not care about I/IDR frame requests, in mode 0 it will generate intra frames, and in mode 1 it will generate full IDR frames. _

Re: [FFmpeg-devel] [PATCH] nvenc: FIX wrong forced keyframe behavior

2017-02-12 Thread Timo Rothenpieler
The current behavior is intended like it is. On the default of -1, it does not care about I/IDR frame requests, in mode 0 it will generate intra frames, and in mode 1 it will generate full IDR frames. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] nvenc: FIX wrong forced keyframe behavior

2017-02-12 Thread Miroslav Slugeň
There was error in forcing key frames. If IDR was set to -1 (default) forced key frame will be never propagated to encoder. I also suggest to backport this patch to current stable version, because -forced_keyframe behavior in NVENC is actualy broken. -- Miroslav Slugeň >From 60a1efef9