Re: [FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread Kieran Kunhya
On 21 August 2014 13:55, Scott Leno wrote: > On Aug 21, 2014 8:07 AM, "Hendrik Leppkes" wrote: >> >> ISO defines id 0x6 as a generic type for private data, its certainly >> not specified by ISO for ARIB subtitles. >> I wonder if adding this might run into problems at some point though, >> if some

Re: [FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread Michael Niedermayer
On Thu, Aug 21, 2014 at 09:42:30PM +0900, Tsukasa ŌMOTO wrote: > > But I believe you should simply remove the hunk > > that sets ISO_types for ARIB. > > updated the patch. > Like this? > libavcodec/avcodec.h|2 ++ > libavcodec/codec_desc.c | 14 ++ > libavformat/mpegts.c

Re: [FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread Scott Leno
On Aug 21, 2014 8:07 AM, "Hendrik Leppkes" wrote: > > ISO defines id 0x6 as a generic type for private data, its certainly > not specified by ISO for ARIB subtitles. > I wonder if adding this might run into problems at some point though, > if something elses uses 0x6. I have seen type 0x06 used w

Re: [FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread Tsukasa ŌMOTO
> But I believe you should simply remove the hunk > that sets ISO_types for ARIB. updated the patch. Like this? 0001-mpegts-support-ARIB-subtitles-in-libavformat.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http:

Re: [FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread Carl Eugen Hoyos
Tsukasa OMOTO gmail.com> writes: > > Shouldn't you add ARIB to DESC_types[]? > > I don't know which ISO_types or DESC_types I should > add to. Do you think DESC_types is better? I probably mixed up stream descriptions and stream identifiers, so ignore this suggestion. But I believe you should

Re: [FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread Hendrik Leppkes
On Thu, Aug 21, 2014 at 1:49 PM, Tsukasa OMOTO wrote: > Hi, Carl > >> Shouldn't you add ARIB to DESC_types[]? > > I don't know which ISO_types or DESC_types I should add to. > Do you think DESC_types is better? > > Tsukasa > ISO defines id 0x6 as a generic type for private data, its certainly not

Re: [FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread Tsukasa OMOTO
Hi, Carl > Shouldn't you add ARIB to DESC_types[]? I don't know which ISO_types or DESC_types I should add to. Do you think DESC_types is better? Tsukasa 2014/08/21 19:26、Carl Eugen Hoyos のメール: > Tsukasa OMOTO gmail.com> writes: > >> I added support of ARIB subtitles to mpegts in >> libavf

Re: [FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread compn
On Thu, 21 Aug 2014 10:26:18 + (UTC) Carl Eugen Hoyos wrote: > Could you provide samples for both types? uploaded to incoming/private-aribu_sub_sample.ts -compn ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listin

Re: [FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread Carl Eugen Hoyos
Tsukasa OMOTO gmail.com> writes: > I added support of ARIB subtitles to mpegts in > libavformat. Shouldn't you add ARIB to DESC_types[]? Could you provide samples for both types? (Ideally even for all stream_identifiers but I guess this isn't possible.) Carl Eugen __

[FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread Tsukasa OMOTO
Hello, I added support of ARIB subtitles to mpegts in libavformat. Regards, Tsukasa. 0001-mpegts-support-ARIB-subtitles-in-libavformat.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listi