Re: [FFmpeg-devel] [PATCH] mpegts: pcr period option for variable bitrate multiplexing

2016-03-29 Thread Predrag Filipovic
Regarding "pcr is different but once the value is correct, mechanism is the same ... pat/sdt" Correct. These are (pcr vs other) or can be identical for CBR. Identical (mechanisms) is OK for VBR (as a matter of principle) but one could also have simpler implementation for pat/sdt since their lower b

Re: [FFmpeg-devel] [PATCH] mpegts: pcr period option for variable bitrate multiplexing

2016-03-28 Thread Michael Niedermayer
On Mon, Mar 28, 2016 at 07:58:29PM -0400, Predrag Filipovic wrote: > Inline answers and some questions/advice_sought are marked by "---" (start > and end) > > Couple of NOTES and a bit more: > > NOTE 1: > PCR is a different "animal" from PCR/PAT/PMT/SDT (PSI's): PSI have upper > bound > deadline

Re: [FFmpeg-devel] [PATCH] mpegts: pcr period option for variable bitrate multiplexing

2016-03-28 Thread Predrag Filipovic
Inline answers and some questions/advice_sought are marked by "---" (start and end) Couple of NOTES and a bit more: NOTE 1: PCR is a different "animal" from PCR/PAT/PMT/SDT (PSI's): PSI have upper bound deadline with no consequences if inserted early while PCR value needs to reflect time at the "

Re: [FFmpeg-devel] [PATCH] mpegts: pcr period option for variable bitrate multiplexing

2016-03-27 Thread Michael Niedermayer
On Fri, Mar 25, 2016 at 12:50:29PM -0400, Predrag Filipovic wrote: > Enable proper PCR insertion for VBR multiplexing (muxrate not specified). > Insertion timing is based on video frame keys and frame period, consequently > pcr period precision is limited to +/- one video frame period. > > Signed-

Re: [FFmpeg-devel] [PATCH] mpegts: pcr period option for variable bitrate multiplexing

2016-03-26 Thread Predrag Filipovic
My sincere apology: - can you please use my originally sent patch that is (exactly) the same as this one ... it was send through different Email server - Feb 19, 2016 19:11:41 EDT (US) - same Subject, from pred...@agora-cs.com I did (tried to) re-send from this new gmail account - had to ope

Re: [FFmpeg-devel] [PATCH] mpegts: pcr period option for variable bitrate multiplexing

2016-03-26 Thread Michael Niedermayer
On Fri, Mar 25, 2016 at 12:50:29PM -0400, Predrag Filipovic wrote: > Enable proper PCR insertion for VBR multiplexing (muxrate not specified). > Insertion timing is based on video frame keys and frame period, consequently > pcr period precision is limited to +/- one video frame period. > > Signed-

[FFmpeg-devel] [PATCH] mpegts: pcr period option for variable bitrate multiplexing

2016-03-25 Thread Predrag Filipovic
Enable proper PCR insertion for VBR multiplexing (muxrate not specified). Insertion timing is based on video frame keys and frame period, consequently pcr period precision is limited to +/- one video frame period. Signed-off-by: Predrag Filipovic --- libavformat/mpegtsenc.c | 80

Re: [FFmpeg-devel] [PATCH] mpegts: pcr period option for variable bitrate multiplexing

2016-03-24 Thread Michael Niedermayer
On Thu, Mar 24, 2016 at 03:14:56PM -0400, Predrag Filipovic wrote: > PCR insertion with specified period is functional when muxrate > is also specified (contant bitrate) as required by DVB and ATSC > (and other) specifications. Feature was non-functional for > variable bitrate (muxrate not specifie

[FFmpeg-devel] [PATCH] mpegts: pcr period option for variable bitrate multiplexing

2016-03-24 Thread Predrag Filipovic
PCR insertion with specified period is functional when muxrate is also specified (contant bitrate) as required by DVB and ATSC (and other) specifications. Feature was non-functional for variable bitrate (muxrate not specified). Insertion timing is based on video frame keys and frame period (dts) th

[FFmpeg-devel] [PATCH] mpegts: pcr period option for variable bitrate multiplexing

2016-02-19 Thread Predrag Filipovic
PCR insertion with specified period is functional when muxrate is also specified (contant bitrate) as required by DVB and ATSC (and other) specifications. Feature was non-functional for variable bitrate (muxrate not specified). Insertion timing is based on video frame keys and frame period (dts) th