Re: [FFmpeg-devel] [PATCH] mpeg2dec: fix decoding field pictures

2018-02-10 Thread Nekopanda
> On Fri, Feb 09, 2018 at 02:03:24AM +0900, Nekopanda wrote: >> - Fix field selection for skipped macroblocks >> >> For B field pictures, the spec says, >> >> > The prediction shall be made from the field of the same parity as the > field being predicted. >> >> I did it. >> >> - Fix moti

Re: [FFmpeg-devel] [PATCH] mpeg2dec: fix decoding field pictures

2018-02-09 Thread Michael Niedermayer
On Fri, Feb 09, 2018 at 02:03:24AM +0900, Nekopanda wrote: > - Fix field selection for skipped macroblocks > > For B field pictures, the spec says, > > > The prediction shall be made from the field of the same parity as the field > > being predicted. > > I did it. > > - Fix motion vector round

Re: [FFmpeg-devel] [PATCH] mpeg2dec: fix decoding field pictures

2018-02-09 Thread Nekopanda
> From: Carl Eugen Hoyos > > 2018-02-09 3:51 GMT+01:00 Nekopanda > : >>> From: Carl Eugen Hoyos >   Yes, I have files that show artifacts without this change. > Recently,   Japanese satellite television started to use field pictures > widely,   and many of that show artifact

Re: [FFmpeg-devel] [PATCH] mpeg2dec: fix decoding field pictures

2018-02-09 Thread Carl Eugen Hoyos
2018-02-09 3:51 GMT+01:00 Nekopanda : >> From: Carl Eugen Hoyos >>> Yes, I have files that show artifacts without this change. Recently, >>> Japanese satellite television started to use field pictures widely, >>> and many of that show artifacts. We need this change to remove >>> the artifacts

Re: [FFmpeg-devel] [PATCH] mpeg2dec: fix decoding field pictures

2018-02-08 Thread Nekopanda
> From: Carl Eugen Hoyos > > 2018-02-09 3:07 GMT+01:00 Nekopanda > : >>> How did you find this bug ? >>> >>> do you have a testcase / file which shows artifacts without this change > ? >> >> Yes, I have files that show artifacts without this change. Recently, >> Japanese satellite televi

Re: [FFmpeg-devel] [PATCH] mpeg2dec: fix decoding field pictures

2018-02-08 Thread Carl Eugen Hoyos
2018-02-09 3:07 GMT+01:00 Nekopanda : >> How did you find this bug ? >> >> do you have a testcase / file which shows artifacts without this change ? > > Yes, I have files that show artifacts without this change. Recently, > Japanese satellite television started to use field pictures widely, > and m

Re: [FFmpeg-devel] [PATCH] mpeg2dec: fix decoding field pictures

2018-02-08 Thread Nekopanda
ter-yadif-mode0 filter-yadif-mode1 mpeg2-field-enc mpeg2-ticket186 mpeg2-ticket6677 - Original Message - > From: Michael Niedermayer > To: FFmpeg development discussions and patches > Cc: > Date: 2018/2/9, Fri 09:55 > Subject: Re: [FFmpeg-devel] [PATCH] mpeg2dec: fix decod

Re: [FFmpeg-devel] [PATCH] mpeg2dec: fix decoding field pictures

2018-02-08 Thread Michael Niedermayer
On Fri, Feb 09, 2018 at 02:03:24AM +0900, Nekopanda wrote: > - Fix field selection for skipped macroblocks > > For B field pictures, the spec says, > > > The prediction shall be made from the field of the same parity as the field > > being predicted. > > I did it. > > - Fix motion vector round

[FFmpeg-devel] [PATCH] mpeg2dec: fix decoding field pictures

2018-02-08 Thread Nekopanda
- Fix field selection for skipped macroblocks For B field pictures, the spec says, > The prediction shall be made from the field of the same parity as the field > being predicted. I did it. - Fix motion vector rounding for chroma components In 16x8 motion compensation, for lower 16x8 region,