Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-06-06 Thread Mathieu Duponchelle
Sorry for pinging again, but at this point I don't know what more I can do to get this (necessary) fix upstream :) On 5/29/19 3:44 PM, Mathieu Duponchelle wrote: > As suggested elsewhere, here's the output of git diff -w, I hope that helps :) > > diff --git a/libavcodec/mpeg12enc.c b/libavcodec/m

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-05-29 Thread Mathieu Duponchelle
As suggested elsewhere, here's the output of git diff -w, I hope that helps :) diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c index 2bc5289d63..0162939399 100644 --- a/libavcodec/mpeg12enc.c +++ b/libavcodec/mpeg12enc.c @@ -547,8 +547,13 @@ void ff_mpeg1_encode_picture_header(Mpe

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-05-20 Thread Reimar Döffinger
On Mon, May 20, 2019 at 10:05:49AM +0200, Hendrik Leppkes wrote: > On Mon, May 20, 2019 at 9:44 AM Reimar Döffinger > wrote: > > On 20.05.2019, at 09:23, Mathieu Duponchelle > > wrote: > > > On 5/19/19 7:00 PM, Devin Heitmueller wrote: > > >> Are you suggesting he should make a patch which resul

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-05-20 Thread Hendrik Leppkes
On Mon, May 20, 2019 at 9:44 AM Reimar Döffinger wrote: > > > > On 20.05.2019, at 09:23, Mathieu Duponchelle wrote: > > > Thanks :) > > > > On 5/19/19 7:00 PM, Devin Heitmueller wrote: > >> Hello Paul, > >> > >> On Fri, May 17, 2019 at 4:44 AM Paul B Mahol wrote: > >>> On 5/17/19, Mathieu Duponc

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-05-20 Thread Reimar Döffinger
On 20.05.2019, at 09:23, Mathieu Duponchelle wrote: > Thanks :) > > On 5/19/19 7:00 PM, Devin Heitmueller wrote: >> Hello Paul, >> >> On Fri, May 17, 2019 at 4:44 AM Paul B Mahol wrote: >>> On 5/17/19, Mathieu Duponchelle wrote: There isn't one, as I said the added indentation is becau

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-05-20 Thread Mathieu Duponchelle
Thanks :) On 5/19/19 7:00 PM, Devin Heitmueller wrote: > Hello Paul, > > On Fri, May 17, 2019 at 4:44 AM Paul B Mahol wrote: >> On 5/17/19, Mathieu Duponchelle wrote: >>> There isn't one, as I said the added indentation is because of the new loop! >> To get this committed to tree you need to com

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-05-20 Thread Mathieu Duponchelle
Hello, Have you read the patch? The request is to split out cosmetic indentation to a separate commit, however the added indentation is not cosmetic, but simply due to a new inner loop .. Best, Mathieu On 5/17/19 10:44 AM, Paul B Mahol wrote: > On 5/17/19, Mathieu Duponchelle wrote: >> There is

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-05-19 Thread Devin Heitmueller
Hello Paul, On Fri, May 17, 2019 at 4:44 AM Paul B Mahol wrote: > > On 5/17/19, Mathieu Duponchelle wrote: > > There isn't one, as I said the added indentation is because of the new loop! > > To get this committed to tree you need to comply to review requests. I think Mathieu's point is that th

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-05-17 Thread Paul B Mahol
On 5/17/19, Mathieu Duponchelle wrote: > There isn't one, as I said the added indentation is because of the new loop! To get this committed to tree you need to comply to review requests. > > On 5/13/19 3:39 PM, Carl Eugen Hoyos wrote: >> Am Mi., 10. Apr. 2019 um 13:26 Uhr schrieb Mathieu Duponch

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-05-16 Thread Mathieu Duponchelle
There isn't one, as I said the added indentation is because of the new loop! On 5/13/19 3:39 PM, Carl Eugen Hoyos wrote: > Am Mi., 10. Apr. 2019 um 13:26 Uhr schrieb Mathieu Duponchelle > : > >> No problem > I don't see an updated patch. > > Carl Eugen > ___

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-05-13 Thread Carl Eugen Hoyos
Am Mi., 10. Apr. 2019 um 13:26 Uhr schrieb Mathieu Duponchelle : > No problem I don't see an updated patch. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link ab

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-05-13 Thread Mathieu Duponchelle
Ping! On 4/19/19 2:46 PM, Mathieu Duponchelle wrote: > Hello ? :) > > On 4/10/19 1:26 PM, Mathieu Duponchelle wrote: >> No problem, note that the added indentation is because a loop >> was added :) >> >> On 4/10/19 1:14 AM, Carl Eugen Hoyos wrote: >>> 2019-03-23 0:22 GMT+01:00, Mathieu Duponchelle

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-04-19 Thread Mathieu Duponchelle
Hello ? :) On 4/10/19 1:26 PM, Mathieu Duponchelle wrote: > No problem, note that the added indentation is because a loop > was added :) > > On 4/10/19 1:14 AM, Carl Eugen Hoyos wrote: >> 2019-03-23 0:22 GMT+01:00, Mathieu Duponchelle : >>> It is perfectly valid to have multiple CC Picture User Da

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-04-10 Thread Mathieu Duponchelle
No problem, note that the added indentation is because a loop was added :) On 4/10/19 1:14 AM, Carl Eugen Hoyos wrote: > 2019-03-23 0:22 GMT+01:00, Mathieu Duponchelle : >> It is perfectly valid to have multiple CC Picture User Data >> for the same frame. Instead of using the first side_data >> po

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-04-09 Thread Carl Eugen Hoyos
2019-03-23 0:22 GMT+01:00, Mathieu Duponchelle : > It is perfectly valid to have multiple CC Picture User Data > for the same frame. Instead of using the first side_data > potentially present with the A53_CC type, iterate over all > side_data. Please separate the functional changes in your patch f

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-04-09 Thread Mathieu Duponchelle
Anyone? :) On 3/23/19 12:22 AM, Mathieu Duponchelle wrote: > It is perfectly valid to have multiple CC Picture User Data > for the same frame. Instead of using the first side_data > potentially present with the A53_CC type, iterate over all > side_data. > --- > libavcodec/mpeg12enc.c | 56 +++

[FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-03-22 Thread Mathieu Duponchelle
It is perfectly valid to have multiple CC Picture User Data for the same frame. Instead of using the first side_data potentially present with the A53_CC type, iterate over all side_data. --- libavcodec/mpeg12enc.c | 56 +++--- 1 file changed, 31 insertions(+), 2