Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for highlight and hilightcolor box

2015-07-12 Thread Philip Langdale
On Sun, 12 Jul 2015 12:50:22 +0530 Niklesh Lalwani wrote: > Updated patch attached. As Philip said, this was not a simple > re-indent, so indentation included. > > Thanks, > > Niklesh Pushed, thanks. --phil ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for highlight and hilightcolor box

2015-07-12 Thread Niklesh Lalwani
On Sun, Jul 12, 2015 at 1:05 PM, Clément Bœsch wrote: > On Tue, Jul 07, 2015 at 08:33:12PM +0530, Niklesh Lalwani wrote: > [...] > > > > +struct Box > > > > +{ > > > > > > style > > > > > > > What about this? > > > > I meant "struct Box {" > > I changed it to "typedef struct {" in the updated pat

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for highlight and hilightcolor box

2015-07-12 Thread Clément Bœsch
On Tue, Jul 07, 2015 at 08:33:12PM +0530, Niklesh Lalwani wrote: [...] > > > +struct Box > > > +{ > > > > style > > > > What about this? > I meant "struct Box {" [...] -- Clément B. pgpXhkbYol9Fe.pgp Description: PGP signature ___ ffmpeg-devel mai

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for highlight and hilightcolor box

2015-07-12 Thread Clément Bœsch
On Thu, Jul 09, 2015 at 11:16:16AM -0700, Philip Langdale wrote: > On 2015-07-06 14:42, Clément Bœsch wrote: > > > >> { > >> int i = 0; > >> int text_pos = 0; > >> while (text < text_end) { > >>-for (i = 0; i < style_entries; i++) { > >>-if (s[i]->style_flag && text_

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for highlight and hilightcolor box

2015-07-12 Thread Niklesh Lalwani
Updated patch attached. As Philip said, this was not a simple re-indent, so indentation included. Thanks, Niklesh From 7dff4a52e41fabe4748076e152cf600d426a5ee8 Mon Sep 17 00:00:00 2001 From: Niklesh Date: Sun, 12 Jul 2015 12:44:48 +0530 Subject: [PATCH] movtextdec.c: Add support for highlight an

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for highlight and hilightcolor box

2015-07-09 Thread Philip Langdale
On 2015-07-06 14:42, Clément Bœsch wrote: { int i = 0; int text_pos = 0; while (text < text_end) { -for (i = 0; i < style_entries; i++) { -if (s[i]->style_flag && text_pos == s[i]->style_end) { -if (s[i]->style_flag & STYLE_FLAG_BOLD) -

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for highlight and hilightcolor box

2015-07-07 Thread Niklesh Lalwani
On Tue, Jul 7, 2015 at 3:12 AM, Clément Bœsch wrote: > On Mon, Jul 06, 2015 at 10:27:47PM +0530, Niklesh Lalwani wrote: > > From: Niklesh > > > > Signed-off-by: Niklesh > > --- > > libavcodec/movtextdec.c | 254 > +--- > > 1 file changed, 173 inserti

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for highlight and hilightcolor box

2015-07-06 Thread Clément Bœsch
On Mon, Jul 06, 2015 at 10:27:47PM +0530, Niklesh Lalwani wrote: > From: Niklesh > > Signed-off-by: Niklesh > --- > libavcodec/movtextdec.c | 254 > +--- > 1 file changed, 173 insertions(+), 81 deletions(-) > > diff --git a/libavcodec/movtextdec.c b

[FFmpeg-devel] [PATCH] movtextdec.c: Add support for highlight and hilightcolor box

2015-07-06 Thread Niklesh Lalwani
From: Niklesh Signed-off-by: Niklesh --- libavcodec/movtextdec.c | 254 +--- 1 file changed, 173 insertions(+), 81 deletions(-) diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c index a3afd91..7e9e4f5 100644 --- a/libavcodec/movtextdec.c

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for highlight and hilightcolor box

2015-07-05 Thread Philip Langdale
On Sun, 5 Jul 2015 15:53:32 +0530 Niklesh Lalwani wrote: > From: Niklesh > > This patch adds support for decoding of Highlight and hilightcolor > box as defined by 3GPP standards. The code is also reorganised to > make it easier to maintain and read. Separate functions are defined > that proce

[FFmpeg-devel] [PATCH] movtextdec.c: Add support for highlight and hilightcolor box

2015-07-05 Thread Niklesh Lalwani
From: Niklesh This patch adds support for decoding of Highlight and hilightcolor box as defined by 3GPP standards. The code is also reorganised to make it easier to maintain and read. Separate functions are defined that process each type of box. Signed-off-by: Niklesh --- libavcodec/movtextd