Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for font names

2015-08-07 Thread Niklesh Lalwani
The leak was happening because the m->count_f was initialised to 0 at the wrong place which was used in freeing the mem allocs. I am posting a patch to fix that. Thanks, Niklesh On Fri, Aug 7, 2015 at 5:11 AM, Michael Niedermayer wrote: > On Thu, Aug 06, 2015 at 09:17:17AM +0530, Niklesh Lalwan

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for font names

2015-08-06 Thread Michael Niedermayer
On Thu, Aug 06, 2015 at 09:17:17AM +0530, Niklesh Lalwani wrote: > Changes incorporated. > Updated patch attached. > > Thanks, > Niklesh > > On Thu, Aug 6, 2015 at 7:51 AM, Philip Langdale wrote: > > > On Thu, 6 Aug 2015 07:13:07 +0530 > > Niklesh Lalwani wrote: > > > > > On Thu, Aug 6, 2015 a

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for font names

2015-08-06 Thread Philip Langdale
On Thu, 6 Aug 2015 09:17:17 +0530 Niklesh Lalwani wrote: > Changes incorporated. > Updated patch attached. Pushed. Thanks. --phil ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for font names

2015-08-05 Thread Niklesh Lalwani
Changes incorporated. Updated patch attached. Thanks, Niklesh On Thu, Aug 6, 2015 at 7:51 AM, Philip Langdale wrote: > On Thu, 6 Aug 2015 07:13:07 +0530 > Niklesh Lalwani wrote: > > > On Thu, Aug 6, 2015 at 2:02 AM, Philip Langdale > > wrote: > > > > > On Thu, 6 Aug 2015 00:12:07 +0530 > > >

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for font names

2015-08-05 Thread Philip Langdale
On Thu, 6 Aug 2015 07:13:07 +0530 Niklesh Lalwani wrote: > On Thu, Aug 6, 2015 at 2:02 AM, Philip Langdale > wrote: > > > On Thu, 6 Aug 2015 00:12:07 +0530 > > Niklesh Lalwani wrote: > > > > > From 90f466bb6a5d3cd24d7ea4d9fd8a2915cc68cdb2 Mon Sep 17 00:00:00 > > > 2001 From: Niklesh > > > Dat

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for font names

2015-08-05 Thread Niklesh Lalwani
On Thu, Aug 6, 2015 at 2:02 AM, Philip Langdale wrote: > On Thu, 6 Aug 2015 00:12:07 +0530 > Niklesh Lalwani wrote: > > > From 90f466bb6a5d3cd24d7ea4d9fd8a2915cc68cdb2 Mon Sep 17 00:00:00 2001 > > From: Niklesh > > Date: Thu, 6 Aug 2015 00:06:15 +0530 > > Subject: [PATCH] movtextdec.c: Add supp

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for font names

2015-08-05 Thread Philip Langdale
On Thu, 6 Aug 2015 00:12:07 +0530 Niklesh Lalwani wrote: > From 90f466bb6a5d3cd24d7ea4d9fd8a2915cc68cdb2 Mon Sep 17 00:00:00 2001 > From: Niklesh > Date: Thu, 6 Aug 2015 00:06:15 +0530 > Subject: [PATCH] movtextdec.c: Add support for font names > > Signed-off-by: Niklesh > --- > libavcodec/mo

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for font names

2015-08-05 Thread Niklesh Lalwani
> I didn't mean this - it's ok for the value to be 0, but it's > not ok for it to be some huge number that will cause you to > read beyond the end of the buffer. So like you did for the other > variable length fields, you need to sanity check this against the total > packet size. > > > +t3xg_pt

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for font names

2015-08-04 Thread Philip Langdale
On Tue, 4 Aug 2015 20:15:58 +0530 Niklesh Lalwani wrote: > From f901f48320140b8f011ec089e6d950e25c90beec Mon Sep 17 00:00:00 2001 > From: Niklesh > Date: Tue, 4 Aug 2015 20:10:28 +0530 > Subject: [PATCH] movtextdec.c: Add support for font names > > Signed-off-by: Niklesh > --- > libavcodec/mo

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for font names

2015-08-04 Thread Niklesh Lalwani
Updated patch. Thanks, Niklesh On Tue, Aug 4, 2015 at 8:58 AM, Philip Langdale wrote: > On Fri, 31 Jul 2015 19:25:58 +0530 > Niklesh Lalwani wrote: > > > From: Niklesh > > > > The font names are extracted from the font table, present in text > > sample entry. More than one fonts can be presen

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for font names

2015-08-03 Thread Philip Langdale
On Fri, 31 Jul 2015 19:25:58 +0530 Niklesh Lalwani wrote: > From: Niklesh > > The font names are extracted from the font table, present in text > sample entry. More than one fonts can be present, which is taken care > of in the patch. > > Signed-off-by: Niklesh > --- > libavcodec/movtextdec.

[FFmpeg-devel] [PATCH] movtextdec.c: Add support for font names

2015-07-31 Thread Niklesh Lalwani
From: Niklesh The font names are extracted from the font table, present in text sample entry. More than one fonts can be present, which is taken care of in the patch. Signed-off-by: Niklesh --- libavcodec/movtextdec.c | 86 +++-- 1 file changed, 83