Re: [FFmpeg-devel] [PATCH] movenc: support GPMF track (gpmd) remuxing

2017-07-24 Thread Clément Bœsch
On Fri, Jul 21, 2017 at 03:18:26PM +0200, Michael Niedermayer wrote: > On Fri, Jul 21, 2017 at 10:30:19AM +0200, Clément Bœsch wrote: > > From: Clément Bœsch > > > > See https://github.com/gopro/gpmf-parser for more information on the > > data stream itself. > > --- > > libavformat/movenc.c | 25

Re: [FFmpeg-devel] [PATCH] movenc: support GPMF track (gpmd) remuxing

2017-07-21 Thread Clément Bœsch
On Fri, Jul 21, 2017 at 04:09:29PM +0200, Clément Bœsch wrote: > On Fri, Jul 21, 2017 at 03:03:19PM +0100, Derek Buitenhuis wrote: > > On 7/21/2017 2:55 PM, Clément Bœsch wrote: > > > It's basically the same layout for every stsd sample description. Check > > > the other tags that extend that layou

Re: [FFmpeg-devel] [PATCH] movenc: support GPMF track (gpmd) remuxing

2017-07-21 Thread Clément Bœsch
On Fri, Jul 21, 2017 at 03:03:19PM +0100, Derek Buitenhuis wrote: > On 7/21/2017 2:55 PM, Clément Bœsch wrote: > > It's basically the same layout for every stsd sample description. Check > > the other tags that extend that layout, the also have that data ref idx to > > 1. I think I copied from the

Re: [FFmpeg-devel] [PATCH] movenc: support GPMF track (gpmd) remuxing

2017-07-21 Thread Derek Buitenhuis
On 7/21/2017 2:55 PM, Clément Bœsch wrote: > It's basically the same layout for every stsd sample description. Check > the other tags that extend that layout, the also have that data ref idx to > 1. I think I copied from the rtp code, but it's the same for the other as > well. This gpmd atom just e

Re: [FFmpeg-devel] [PATCH] movenc: support GPMF track (gpmd) remuxing

2017-07-21 Thread Clément Bœsch
On Fri, Jul 21, 2017 at 02:21:23PM +0100, Derek Buitenhuis wrote: > On 7/21/2017 9:30 AM, Clément Bœsch wrote: > > +avio_wb16(pb, 1); /* Data-reference index */ > > Why is this whole atom hardcoded (i.e. with is '1'). > It's basically the same layout for every stsd sample description. Check

Re: [FFmpeg-devel] [PATCH] movenc: support GPMF track (gpmd) remuxing

2017-07-21 Thread Derek Buitenhuis
On 7/21/2017 9:30 AM, Clément Bœsch wrote: > +avio_wb16(pb, 1); /* Data-reference index */ Why is this whole atom hardcoded (i.e. with is '1'). - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-d

Re: [FFmpeg-devel] [PATCH] movenc: support GPMF track (gpmd) remuxing

2017-07-21 Thread Michael Niedermayer
On Fri, Jul 21, 2017 at 10:30:19AM +0200, Clément Bœsch wrote: > From: Clément Bœsch > > See https://github.com/gopro/gpmf-parser for more information on the > data stream itself. > --- > libavformat/movenc.c | 25 + > 1 file changed, 25 insertions(+) can you add a fate

[FFmpeg-devel] [PATCH] movenc: support GPMF track (gpmd) remuxing

2017-07-21 Thread Clément Bœsch
From: Clément Bœsch See https://github.com/gopro/gpmf-parser for more information on the data stream itself. --- libavformat/movenc.c | 25 + 1 file changed, 25 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 3989ac167e..0e5b45d150 100644 ---