Re: [FFmpeg-devel] [PATCH] movenc: Get rid of frag_start

2021-08-18 Thread Martin Storsjö
On Thu, 12 Aug 2021, Martin Storsjö wrote: On Thu, 12 Aug 2021, Hu Weiwen wrote: "frag_start" is redundant, and every occurance can be replaced with cluster[0].dts - start_dts I think I can agree about this, so I think the patch should be fine, thanks for taking the time to study it in deta

Re: [FFmpeg-devel] [PATCH] movenc: Get rid of frag_start

2021-08-12 Thread Martin Storsjö
On Thu, 12 Aug 2021, Hu Weiwen wrote: "frag_start" is redundant, and every occurance can be replaced with cluster[0].dts - start_dts I think I can agree about this, so I think the patch should be fine, thanks for taking the time to study it in detail! My own mental model of the code, having

[FFmpeg-devel] [PATCH] movenc: Get rid of frag_start

2021-08-11 Thread Hu Weiwen
"frag_start" is redundant, and every occurance can be replaced with cluster[0].dts - start_dts The proof of no behaviour changes: (All line number below is based on commit bff7d662d728) "frag_start" is read at 4 place (with all possible call stacks): mov_write_packet ... mov_flush_fragment