Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-23 Thread John Stebbins
On 10/23/2017 03:24 AM, Michael Niedermayer wrote: > On Thu, Oct 12, 2017 at 10:59:23AM -0700, John Stebbins wrote: >> When keyframe intervals of dash segments are not perfectly aligned, >> fragments in the stream can overlap in time. The previous sorting by >> timestamp causes packets to be read o

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-23 Thread Michael Niedermayer
On Thu, Oct 12, 2017 at 10:59:23AM -0700, John Stebbins wrote: > When keyframe intervals of dash segments are not perfectly aligned, > fragments in the stream can overlap in time. The previous sorting by > timestamp causes packets to be read out of decode order and results > in decode errors. > >

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-22 Thread John Stebbins
On 10/12/2017 10:59 AM, John Stebbins wrote: > When keyframe intervals of dash segments are not perfectly aligned, > fragments in the stream can overlap in time. The previous sorting by > timestamp causes packets to be read out of decode order and results > in decode errors. > > Insert new "trun" i

[FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-12 Thread John Stebbins
When keyframe intervals of dash segments are not perfectly aligned, fragments in the stream can overlap in time. The previous sorting by timestamp causes packets to be read out of decode order and results in decode errors. Insert new "trun" index entries into index_entries in the order that the tr

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-12 Thread John Stebbins
On 10/12/2017 10:22 AM, Michael Niedermayer wrote: > On Wed, Oct 11, 2017 at 10:56:41PM -0700, John Stebbins wrote: >> On 10/11/2017 06:25 PM, Michael Niedermayer wrote: >>> On Tue, Oct 10, 2017 at 06:11:08PM -0700, John Stebbins wrote: When keyframe intervals of dash segments are not perfectl

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-12 Thread Michael Niedermayer
On Wed, Oct 11, 2017 at 10:56:41PM -0700, John Stebbins wrote: > On 10/11/2017 06:25 PM, Michael Niedermayer wrote: > >On Tue, Oct 10, 2017 at 06:11:08PM -0700, John Stebbins wrote: > >>When keyframe intervals of dash segments are not perfectly aligned, > >>fragments in the stream can overlap in ti

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-11 Thread John Stebbins
On 10/11/2017 06:25 PM, Michael Niedermayer wrote: On Tue, Oct 10, 2017 at 06:11:08PM -0700, John Stebbins wrote: When keyframe intervals of dash segments are not perfectly aligned, fragments in the stream can overlap in time. The previous sorting by timestamp causes packets to be read out of de

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-11 Thread John Stebbins
On 10/11/2017 06:25 PM, Michael Niedermayer wrote: > On Tue, Oct 10, 2017 at 06:11:08PM -0700, John Stebbins wrote: >> When keyframe intervals of dash segments are not perfectly aligned, >> fragments in the stream can overlap in time. The previous sorting by >> timestamp causes packets to be read o

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-11 Thread Michael Niedermayer
On Tue, Oct 10, 2017 at 06:11:08PM -0700, John Stebbins wrote: > When keyframe intervals of dash segments are not perfectly aligned, > fragments in the stream can overlap in time. The previous sorting by > timestamp causes packets to be read out of decode order and results > in decode errors. > >

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-10 Thread John Stebbins
On 10/10/2017 09:57 AM, Michael Niedermayer wrote: > On Mon, Oct 09, 2017 at 01:09:11PM -0700, John Stebbins wrote: >> When keyframe intervals of dash segments are not perfectly aligned, >> fragments in the stream can overlap in time. The previous sorting by >> timestamp causes packets to be read o

[FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-10 Thread John Stebbins
When keyframe intervals of dash segments are not perfectly aligned, fragments in the stream can overlap in time. The previous sorting by timestamp causes packets to be read out of decode order and results in decode errors. Insert new "trun" index entries into index_entries in the order that the tr

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-10 Thread Michael Niedermayer
On Mon, Oct 09, 2017 at 01:09:11PM -0700, John Stebbins wrote: > When keyframe intervals of dash segments are not perfectly aligned, > fragments in the stream can overlap in time. The previous sorting by > timestamp causes packets to be read out of decode order and results > in decode errors. > >

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-09 Thread John Stebbins
On 10/09/2017 02:40 PM, Carl Eugen Hoyos wrote: > 2017-10-09 22:09 GMT+02:00 John Stebbins : > >> +// This shouldn't happen >> +return NULL; > As in: This cannot happen and should be an assert() > or this does not happen for valid files and should print > an error? > > Same below. > > In t

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-09 Thread Carl Eugen Hoyos
2017-10-09 22:09 GMT+02:00 John Stebbins : > +// This shouldn't happen > +return NULL; As in: This cannot happen and should be an assert() or this does not happen for valid files and should print an error? Same below. Carl Eugen ___ ffmpeg-dev

[FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-09 Thread John Stebbins
When keyframe intervals of dash segments are not perfectly aligned, fragments in the stream can overlap in time. The previous sorting by timestamp causes packets to be read out of decode order and results in decode errors. Insert new "trun" index entries into index_entries in the order that the tr

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-28 Thread John Stebbins
On 09/26/2017 05:12 PM, Michael Niedermayer wrote: Hi On Mon, Sep 25, 2017 at 02:12:26PM -0700, John Stebbins wrote: On 09/25/2017 01:12 PM, Carl Eugen Hoyos wrote: 2017-09-25 19:10 GMT+02:00 John Stebbins : When keyframe intervals of dash segments are not perfectly aligned, fragments in the

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-26 Thread Michael Niedermayer
Hi On Mon, Sep 25, 2017 at 02:12:26PM -0700, John Stebbins wrote: > > > On 09/25/2017 01:12 PM, Carl Eugen Hoyos wrote: > > 2017-09-25 19:10 GMT+02:00 John Stebbins : > >> When keyframe intervals of dash segments are not perfectly aligned, > >> fragments in the stream can overlap in time. Append

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-25 Thread John Stebbins
On 09/25/2017 02:27 PM, Carl Eugen Hoyos wrote: > 2017-09-25 23:12 GMT+02:00 John Stebbins : >> FYI, such a facility for marking frames to drop would also >> be useful for frame accurate playback of MP4 edit lists. > Do you have samples with edit lists that do not play > correctly with current FFmp

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-25 Thread Carl Eugen Hoyos
2017-09-25 23:12 GMT+02:00 John Stebbins : > FYI, such a facility for marking frames to drop would also > be useful for frame accurate playback of MP4 edit lists. Do you have samples with edit lists that do not play correctly with current FFmpeg? (Others will hopefully comment on this issue, I ce

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-25 Thread John Stebbins
On 09/25/2017 01:12 PM, Carl Eugen Hoyos wrote: > 2017-09-25 19:10 GMT+02:00 John Stebbins : >> When keyframe intervals of dash segments are not perfectly aligned, >> fragments in the stream can overlap in time. Append new "trun" index >> entries to the end of the index instead of sorting by time

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-25 Thread Carl Eugen Hoyos
2017-09-25 19:10 GMT+02:00 John Stebbins : > When keyframe intervals of dash segments are not perfectly aligned, > fragments in the stream can overlap in time. Append new "trun" index > entries to the end of the index instead of sorting by timestamp. > Sorting by timestamp causes packets to be read

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-25 Thread John Stebbins
On 09/25/2017 10:31 AM, wm4 wrote: > On Mon, 25 Sep 2017 10:10:58 -0700 > John Stebbins wrote: > >> When keyframe intervals of dash segments are not perfectly aligned, >> fragments in the stream can overlap in time. Append new "trun" index >> entries to the end of the index instead of sorting by t

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-25 Thread John Stebbins
On 09/25/2017 10:12 AM, Carl Eugen Hoyos wrote: > 2017-09-25 19:10 GMT+02:00 John Stebbins : >> When keyframe intervals of dash segments are not perfectly aligned, >> fragments in the stream can overlap in time. Append new "trun" index >> entries to the end of the index instead of sorting by timest

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-25 Thread wm4
On Mon, 25 Sep 2017 10:10:58 -0700 John Stebbins wrote: > When keyframe intervals of dash segments are not perfectly aligned, > fragments in the stream can overlap in time. Append new "trun" index > entries to the end of the index instead of sorting by timestamp. > Sorting by timestamp causes pac

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-25 Thread Carl Eugen Hoyos
2017-09-25 19:10 GMT+02:00 John Stebbins : > When keyframe intervals of dash segments are not perfectly aligned, > fragments in the stream can overlap in time. Append new "trun" index > entries to the end of the index instead of sorting by timestamp. > Sorting by timestamp causes packets to be read

[FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-25 Thread John Stebbins
When keyframe intervals of dash segments are not perfectly aligned, fragments in the stream can overlap in time. Append new "trun" index entries to the end of the index instead of sorting by timestamp. Sorting by timestamp causes packets to be read out of decode order and results in decode errors.