Re: [FFmpeg-devel] [PATCH] mov: do not mark timed thumbnail tracks as attached picture

2018-01-27 Thread wm4
On Sat, 27 Jan 2018 18:07:53 +0100 (CET) Marton Balint wrote: > On Sat, 27 Jan 2018, wm4 wrote: > > >> Docs in avformat.h only says that AV_DISPOSITION_ATTACHED_PIC "usually" > >> contains one packet. > > > > It also implies AVStream.attached_pic is set, which can be only one > > picture. >

Re: [FFmpeg-devel] [PATCH] mov: do not mark timed thumbnail tracks as attached picture

2018-01-27 Thread Marton Balint
On Sat, 27 Jan 2018, wm4 wrote: Docs in avformat.h only says that AV_DISPOSITION_ATTACHED_PIC "usually" contains one packet. It also implies AVStream.attached_pic is set, which can be only one picture. From the docs I'd assume that attached_pic contains the _first_ packet of the stream if

Re: [FFmpeg-devel] [PATCH] mov: do not mark timed thumbnail tracks as attached picture

2018-01-26 Thread wm4
On Sat, 27 Jan 2018 01:44:04 +0100 (CET) Marton Balint wrote: > On Sat, 27 Jan 2018, wm4 wrote: > > > The AV_DISPOSITION_ATTACHED_PIC flag is meant only for exporting a > > static picture (such as embedded cover art) as pseudo video track. The > > requirement is that there is exactly 1 packet, a

Re: [FFmpeg-devel] [PATCH] mov: do not mark timed thumbnail tracks as attached picture

2018-01-26 Thread Marton Balint
On Sat, 27 Jan 2018, wm4 wrote: The AV_DISPOSITION_ATTACHED_PIC flag is meant only for exporting a static picture (such as embedded cover art) as pseudo video track. The requirement is that there is exactly 1 packet, and that normal demuxing does not return it (otherwise avformat_queue_attache

[FFmpeg-devel] [PATCH] mov: do not mark timed thumbnail tracks as attached picture

2018-01-26 Thread wm4
The AV_DISPOSITION_ATTACHED_PIC flag is meant only for exporting a static picture (such as embedded cover art) as pseudo video track. The requirement is that there is exactly 1 packet, and that normal demuxing does not return it (otherwise avformat_queue_attached_pictures() would add it a second ti