Re: [FFmpeg-devel] [PATCH] mjpegenc: enable optimal huffman coding by default

2017-04-08 Thread Rostislav Pehlivanov
On 5 April 2017 at 20:05, Michael Niedermayer wrote: > On Tue, Apr 04, 2017 at 04:10:39PM +0200, Michael Niedermayer wrote: > > On Tue, Apr 04, 2017 at 03:59:28PM +0200, Michael Niedermayer wrote: > > > On Tue, Apr 04, 2017 at 11:00:23AM +0100, Rostislav Pehlivanov wrote: > > > > On 4 April 2017

Re: [FFmpeg-devel] [PATCH] mjpegenc: enable optimal huffman coding by default

2017-04-05 Thread Michael Niedermayer
On Tue, Apr 04, 2017 at 04:10:39PM +0200, Michael Niedermayer wrote: > On Tue, Apr 04, 2017 at 03:59:28PM +0200, Michael Niedermayer wrote: > > On Tue, Apr 04, 2017 at 11:00:23AM +0100, Rostislav Pehlivanov wrote: > > > On 4 April 2017 at 02:54, Michael Niedermayer > > > wrote: > > > > > > > On M

Re: [FFmpeg-devel] [PATCH] mjpegenc: enable optimal huffman coding by default

2017-04-04 Thread Michael Niedermayer
On Tue, Apr 04, 2017 at 03:59:28PM +0200, Michael Niedermayer wrote: > On Tue, Apr 04, 2017 at 11:00:23AM +0100, Rostislav Pehlivanov wrote: > > On 4 April 2017 at 02:54, Michael Niedermayer > > wrote: > > > > > On Mon, Apr 03, 2017 at 10:31:27PM +0100, Rostislav Pehlivanov wrote: > > > > As it g

Re: [FFmpeg-devel] [PATCH] mjpegenc: enable optimal huffman coding by default

2017-04-04 Thread Michael Niedermayer
On Tue, Apr 04, 2017 at 11:00:23AM +0100, Rostislav Pehlivanov wrote: > On 4 April 2017 at 02:54, Michael Niedermayer > wrote: > > > On Mon, Apr 03, 2017 at 10:31:27PM +0100, Rostislav Pehlivanov wrote: > > > As it gives excellent encoding gains at an insignificant speed increase > > > and passes

Re: [FFmpeg-devel] [PATCH] mjpegenc: enable optimal huffman coding by default

2017-04-04 Thread Rostislav Pehlivanov
On 4 April 2017 at 02:54, Michael Niedermayer wrote: > On Mon, Apr 03, 2017 at 10:31:27PM +0100, Rostislav Pehlivanov wrote: > > As it gives excellent encoding gains at an insignificant speed increase > > and passes fate without problems, it should now be safe to enable by > > default. > > Still

Re: [FFmpeg-devel] [PATCH] mjpegenc: enable optimal huffman coding by default

2017-04-03 Thread Michael Niedermayer
On Mon, Apr 03, 2017 at 10:31:27PM +0100, Rostislav Pehlivanov wrote: > As it gives excellent encoding gains at an insignificant speed increase > and passes fate without problems, it should now be safe to enable by > default. Still breaks slice threading both Assertion n <= 31 && value < (1U << n

[FFmpeg-devel] [PATCH] mjpegenc: enable optimal huffman coding by default

2017-04-03 Thread Rostislav Pehlivanov
As it gives excellent encoding gains at an insignificant speed increase and passes fate without problems, it should now be safe to enable by default. Signed-off-by: Rostislav Pehlivanov --- Had to add some missing tests --- libavcodec/mjpegenc.c| 2 +- tests/ref/lavf/jpg