Re: [FFmpeg-devel] [PATCH] libxvid: Create extradata in init using a dummy frame

2016-04-04 Thread Michael Niedermayer
On Sun, Apr 03, 2016 at 04:54:47PM -0400, Derek Buitenhuis wrote: > Modifying global header extradata in encode_frame is an API violation > and only happens to work currently because mov writes its header > at the end of the file. > > Heavily based off of a patch from 2012. > > Original-by: Nicol

Re: [FFmpeg-devel] [PATCH] libxvid: Create extradata in init using a dummy frame

2016-04-03 Thread Derek Buitenhuis
On 4/3/2016 9:54 PM, Derek Buitenhuis wrote: > Modifying global header extradata in encode_frame is an API violation > and only happens to work currently because mov writes its header > at the end of the file. > > Heavily based off of a patch from 2012. > > Original-by: Nicolas George > Signed-o

[FFmpeg-devel] [PATCH] libxvid: Create extradata in init using a dummy frame

2016-04-03 Thread Derek Buitenhuis
Modifying global header extradata in encode_frame is an API violation and only happens to work currently because mov writes its header at the end of the file. Heavily based off of a patch from 2012. Original-by: Nicolas George Signed-off-by: Derek Buitenhuis --- libavcodec/libxvid.c | 39 +

Re: [FFmpeg-devel] [PATCH] libxvid: Create extradata in init using a dummy frame

2016-04-03 Thread Michael Niedermayer
On Sun, Apr 03, 2016 at 12:57:28PM -0400, Derek Buitenhuis wrote: > Modifying global header extradata in encode_frame is an API violation > and only happens to work currently because mov writes its header > at the end of the file. > > Heavily based off of a patch from 2012. > > Original-by: Nicol

[FFmpeg-devel] [PATCH] libxvid: Create extradata in init using a dummy frame

2016-04-03 Thread Derek Buitenhuis
Modifying global header extradata in encode_frame is an API violation and only happens to work currently because mov writes its header at the end of the file. Heavily based off of a patch from 2012. Original-by: Nicolas George Signed-off-by: Derek Buitenhuis --- libavcodec/libxvid.c | 37 +