Re: [FFmpeg-devel] [PATCH] libkvazaar: Set frame rate as a rational number

2016-01-19 Thread Arttu Ylä-Outinen
On 2016-01-18 15:46, Nicolas George wrote: EOVERFLOW does not exist on some windows versions. IIRC, we usually use EINVAL in this kind of case. Thanks. I'll change that to EINVAL and apply the patch tomorrow if there are no other issues. - Arttu

Re: [FFmpeg-devel] [PATCH] libkvazaar: Set frame rate as a rational number

2016-01-18 Thread Nicolas George
Le nonidi 29 nivôse, an CCXXIV, Arttu Ylä-Outinen a écrit : > On 2016-01-16 03:31, Michael Niedermayer wrote: > > >its probably rather unlikely but the multiplication could overflow > > Thanks for taking a look. I attached an updated patch which checks for > overflow before multiplying. > > - Ar

Re: [FFmpeg-devel] [PATCH] libkvazaar: Set frame rate as a rational number

2016-01-18 Thread Arttu Ylä-Outinen
On 2016-01-16 03:31, Michael Niedermayer wrote: its probably rather unlikely but the multiplication could overflow Thanks for taking a look. I attached an updated patch which checks for overflow before multiplying. - Arttu >From 0a8a1a1fffd008d43ec601b7e0a5ed22c2c1f784 Mon Sep 17 00:00:00

Re: [FFmpeg-devel] [PATCH] libkvazaar: Set frame rate as a rational number

2016-01-15 Thread Michael Niedermayer
On Fri, Jan 15, 2016 at 03:42:29PM +0200, Arttu Ylä-Outinen wrote: > Updates libkvazaar to pass the exact frame rate to Kvazaar by setting > the numerator and denominator separately instead of a single floating > point number. The exact frame rate is needed for writing timing info to > the bitstrea

[FFmpeg-devel] [PATCH] libkvazaar: Set frame rate as a rational number

2016-01-15 Thread Arttu Ylä-Outinen
Updates libkvazaar to pass the exact frame rate to Kvazaar by setting the numerator and denominator separately instead of a single floating point number. The exact frame rate is needed for writing timing info to the bitstream. Requires Kvazaar version 0.8.1. Signed-off-by: Arttu Ylä-Outinen ---