Re: [FFmpeg-devel] [PATCH] libavutil/encryption_info: Add NULL checks.

2018-06-07 Thread Jacob Trimble
On Tue, Jun 5, 2018 at 1:06 PM Mark Thompson wrote: > > On 05/06/18 17:30, Jacob Trimble wrote: > > Just because I can't check whether my food has salmonella doesn't mean > > I shouldn't check the temperature when I cook it. Adding a NULL check > > is trivial and will catch the most common error

Re: [FFmpeg-devel] [PATCH] libavutil/encryption_info: Add NULL checks.

2018-06-05 Thread Mark Thompson
On 05/06/18 17:30, Jacob Trimble wrote: > Just because I can't check whether my food has salmonella doesn't mean > I shouldn't check the temperature when I cook it. Adding a NULL check > is trivial and will catch the most common error case. We also can't > check whether malloc() allocates enough

Re: [FFmpeg-devel] [PATCH] libavutil/encryption_info: Add NULL checks.

2018-06-05 Thread Michael Niedermayer
On Tue, Jun 05, 2018 at 09:30:51AM -0700, Jacob Trimble wrote: > On Mon, Jun 4, 2018 at 2:24 PM Carl Eugen Hoyos wrote: > > > > 2018-06-04 23:07 GMT+02:00, Jacob Trimble > > : > > > On Mon, Jun 4, 2018 at 10:46 AM Carl Eugen Hoyos > > > wrote: > > >> > > >> 2018-06-04 18:59 GMT+02:00, Jacob Tri

Re: [FFmpeg-devel] [PATCH] libavutil/encryption_info: Add NULL checks.

2018-06-05 Thread Jacob Trimble
On Mon, Jun 4, 2018 at 2:24 PM Carl Eugen Hoyos wrote: > > 2018-06-04 23:07 GMT+02:00, Jacob Trimble : > > On Mon, Jun 4, 2018 at 10:46 AM Carl Eugen Hoyos wrote: > >> > >> 2018-06-04 18:59 GMT+02:00, Jacob Trimble > >> : > >> > On Fri, Jun 1, 2018 at 5:03 PM Michael Niedermayer > >> > wrote: >

Re: [FFmpeg-devel] [PATCH] libavutil/encryption_info: Add NULL checks.

2018-06-04 Thread Carl Eugen Hoyos
2018-06-04 23:07 GMT+02:00, Jacob Trimble : > On Mon, Jun 4, 2018 at 10:46 AM Carl Eugen Hoyos wrote: >> >> 2018-06-04 18:59 GMT+02:00, Jacob Trimble >> : >> > On Fri, Jun 1, 2018 at 5:03 PM Michael Niedermayer >> > wrote: >> >> >> >> On Thu, May 31, 2018 at 09:33:36AM -0700, Jacob Trimble wrote:

Re: [FFmpeg-devel] [PATCH] libavutil/encryption_info: Add NULL checks.

2018-06-04 Thread Jacob Trimble
On Mon, Jun 4, 2018 at 10:46 AM Carl Eugen Hoyos wrote: > > 2018-06-04 18:59 GMT+02:00, Jacob Trimble : > > On Fri, Jun 1, 2018 at 5:03 PM Michael Niedermayer > > wrote: > >> > >> On Thu, May 31, 2018 at 09:33:36AM -0700, Jacob Trimble wrote: > >> > Found by Chrome's ClusterFuzz: http://crbug.com

Re: [FFmpeg-devel] [PATCH] libavutil/encryption_info: Add NULL checks.

2018-06-04 Thread Carl Eugen Hoyos
2018-06-04 18:59 GMT+02:00, Jacob Trimble : > On Fri, Jun 1, 2018 at 5:03 PM Michael Niedermayer > wrote: >> >> On Thu, May 31, 2018 at 09:33:36AM -0700, Jacob Trimble wrote: >> > Found by Chrome's ClusterFuzz: http://crbug.com/846662. >> > >> > Signed-off-by: Jacob Trimble >> > --- >> > libavut

Re: [FFmpeg-devel] [PATCH] libavutil/encryption_info: Add NULL checks.

2018-06-04 Thread Jacob Trimble
On Fri, Jun 1, 2018 at 5:03 PM Michael Niedermayer wrote: > > On Thu, May 31, 2018 at 09:33:36AM -0700, Jacob Trimble wrote: > > Found by Chrome's ClusterFuzz: http://crbug.com/846662. > > > > Signed-off-by: Jacob Trimble > > --- > > libavutil/encryption_info.c | 7 +-- > > 1 file changed, 5

Re: [FFmpeg-devel] [PATCH] libavutil/encryption_info: Add NULL checks.

2018-06-01 Thread Michael Niedermayer
On Thu, May 31, 2018 at 09:33:36AM -0700, Jacob Trimble wrote: > Found by Chrome's ClusterFuzz: http://crbug.com/846662. > > Signed-off-by: Jacob Trimble > --- > libavutil/encryption_info.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/libavutil/encryption_info

[FFmpeg-devel] [PATCH] libavutil/encryption_info: Add NULL checks.

2018-05-31 Thread Jacob Trimble
Found by Chrome's ClusterFuzz: http://crbug.com/846662. Signed-off-by: Jacob Trimble --- libavutil/encryption_info.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavutil/encryption_info.c b/libavutil/encryption_info.c index 20a752d6b4..a48ded922c 100644 --- a/liba