Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc: omit segment UID for webm

2016-07-26 Thread James Almer
On 7/26/2016 2:47 PM, Michael Bradshaw wrote: > Could this patch please be reapplied? It seems like it was accidentally > reverted in commit 5d48e4eafa6c4559683892b8638d10508125f3cf Done. I wonder how a merge did that to begin with. ___ ffmpeg-devel mail

Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc: omit segment UID for webm

2016-07-26 Thread Michael Bradshaw
Could this patch please be reapplied? It seems like it was accidentally reverted in commit 5d48e4eafa6c4559683892b8638d10508125f3cf ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc: omit segment UID for webm

2016-06-22 Thread Michael Niedermayer
On Tue, Jun 21, 2016 at 04:38:55PM -0400, Dave Rice wrote: > > > On Jun 21, 2016, at 3:22 PM, Michael Niedermayer > > wrote: > > > > On Mon, Jun 20, 2016 at 08:20:47PM -0700, Michael Bradshaw wrote: > >> Hi, > >> > >> Attached patch removes SegmentUID element from WebM files, as it's > >> unsu

Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc: omit segment UID for webm

2016-06-22 Thread Dave Rice
> On Jun 22, 2016, at 10:16 AM, Michael Bradshaw wrote: > > On Tue, Jun 21, 2016 at 12:22 PM, Michael Niedermayer > wrote: >> what does "supported" / "unsupported" mean, is this defined somewhere ? > > As far as WebM is concerned, SegmentUID doesn't exist. > > In this situation, writing Segme

Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc: omit segment UID for webm

2016-06-22 Thread Michael Bradshaw
On Tue, Jun 21, 2016 at 12:22 PM, Michael Niedermayer wrote: > what does "supported" / "unsupported" mean, is this defined somewhere ? As far as WebM is concerned, SegmentUID doesn't exist. In this situation, writing SegmentUID is Undefined-Ignore or Optional-Fail/Forbidden, depending on the fil

Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc: omit segment UID for webm

2016-06-21 Thread Dave Rice
> On Jun 21, 2016, at 3:22 PM, Michael Niedermayer > wrote: > > On Mon, Jun 20, 2016 at 08:20:47PM -0700, Michael Bradshaw wrote: >> Hi, >> >> Attached patch removes SegmentUID element from WebM files, as it's >> unsupported in WebM[1]. >> >> Please review/apply. >> >> Thanks, >> >> Michael

Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc: omit segment UID for webm

2016-06-21 Thread Michael Niedermayer
On Mon, Jun 20, 2016 at 08:20:47PM -0700, Michael Bradshaw wrote: > Hi, > > Attached patch removes SegmentUID element from WebM files, as it's > unsupported in WebM[1]. > > Please review/apply. > > Thanks, > > Michael > > [1]: https://www.webmproject.org/docs/container/#SegmentUID what does "

[FFmpeg-devel] [PATCH] libavformat/matroskaenc: omit segment UID for webm

2016-06-20 Thread Michael Bradshaw
Hi, Attached patch removes SegmentUID element from WebM files, as it's unsupported in WebM[1]. Please review/apply. Thanks, Michael [1]: https://www.webmproject.org/docs/container/#SegmentUID 0001-libavformat-matroskaenc-omit-segment-UID-for-webm.patch Description: Binary data __